Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#32742 closed enhancement (fixed)

Menu Customizer: link to the widgets panel in the menus panel description

Reported by: celloexpressions's profile celloexpressions Owned by: westonruter's profile westonruter
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch commit
Focuses: ui Cc:

Description

This is a nice way to give users a path to discovering different features by cross-linking within the Customizer. Patch also removes the part about widgets if the current theme doesn't support widgets.

Attachments (5)

32742.diff (1.7 KB) - added by celloexpressions 10 years ago.
32742.2.diff (1.7 KB) - added by westonruter 10 years ago.
https://github.com/xwp/wordpress-develop/commit/5d148d21059bfba796d1971c732335ee89fd30d0?w=1
panel description screenshot.png (102.6 KB) - added by westonruter 10 years ago.
image.jpg (233.3 KB) - added by ryan 10 years ago.
iphone 6+
menu panel details macnchrome.png (2.1 MB) - added by ryan 10 years ago.
Menu panel details showing link to widgets, Macnchrome

Change History (16)

#1 @celloexpressions
10 years ago

  • Owner set to westonruter
  • Status changed from new to assigned

@westonruter: want to review/commit? Or @ocean90? This is a nice simple improvement.

#2 @westonruter
10 years ago

Can the markup be eliminated from the translated string? Not sure immediately how that would be done, but see also #32817.

#3 @celloexpressions
10 years ago

I believe standard practice with things like links that really need to be in the middle of the string is to leave the tags, but extract as much as possible (ex. the href attribute) to placeholders. Breaking it up into separate strings would be more of a burden for translators, and often wouldn't work. But @ocean90 could elaborate if there's a better way here.

I believe I remember seeing somewhere that translators are generally fine with basic tags like <a> when they're needed. In #32817, we obviously don't need the span to be in the string because it wraps the whole string.

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


10 years ago

#5 @obenland
10 years ago

  • Keywords commit added

Yes, the single anchor tag is fine.

This ticket was mentioned in Slack in #core by obenland. View the logs.


10 years ago

#7 @westonruter
10 years ago

I'll commit this with curly quotes.

#8 @westonruter
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33036:

Customizer: Add link to Widgets panel from Menus panel description.

Props celloexpressions.
Fixes #32742.

#9 @ryan
10 years ago

  • Keywords needs-screenshots added; has-patch commit removed

#10 follow-up: @ocean90
10 years ago

  • Keywords has-patch commit added; needs-screenshots removed

Screenshot is in comment:7.

@ryan
10 years ago

iphone 6+

@ryan
10 years ago

Menu panel details showing link to widgets, Macnchrome

#11 in reply to: ↑ 10 @ryan
10 years ago

Replying to ocean90:

Screenshot is in comment:7.

I do desktop and mobile screenshots in full context on physical devices.

Note: See TracTickets for help on using tickets.