WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#32749 closed defect (bug) (fixed)

Missing CEST time zone in SimplePie

Reported by: Krstarica Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2.2
Component: External Libraries Keywords: has-patch dev-feedback
Focuses: Cc:
PR Number:

Description

Central European Summer Time (CEST) is missing in SimplePie (wp-includes/SimplePie/Parse/Date.php).

This time zone is used by 30 European countries right now:
https://en.wikipedia.org/?title=Central_European_Summer_Time

The fix is available:
https://github.com/simplepie/simplepie/pull/380

It seems that the new version of SimplePie will not be released anytime soon (active v1.3.1 is released on 30 October 2012), so it would be nice to patch this file directly. Many thanks.

Attachments (1)

32749.diff (395 bytes) - added by swissspidy 4 years ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


4 years ago

@swissspidy
4 years ago

#2 @swissspidy
4 years ago

  • Keywords has-patch added

This is a simple patch that just adds the CEST timezone.

#3 @wonderboymusic
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

You need to make a PR here:
https://github.com/simplepie/simplepie/blob/master/library/SimplePie/Parse/Date.php

it's a 3rd party library - once the fix is made upstream, we can fold in the changes

#4 @dd32
4 years ago

  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

As above, there's a PR open.

When an issue in an external library affects core, we also often keep a tracking ticket open. For this, if it affects users majorly, we can merge it even before the next simplepie is released if need be.

#5 @SergeyBiryukov
4 years ago

  • Owner set to rmccue
  • Status changed from reopened to assigned

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


4 years ago

#7 @swissspidy
4 years ago

  • Keywords dev-feedback added

For this, if it affects users majorly, we can merge it even before the next simplepie is released if need be.

Not sure how many have even noticed this bug. Either we fix this now or close it in favor of waiting for a SimplePie release.

It would be good to get a quick feedback from @rmccue on this.

#8 @rmccue
4 years ago

I'll merge upstream right now. I don't dedicate any time to SimplePie, so things like this slip under my radar.

#9 @swissspidy
4 years ago

  • Owner changed from rmccue to wonderboymusic
  • Status changed from assigned to reviewing

If it affects users majorly, we can merge it even before the next simplepie is released if need be.

There won't be a new SimplePie release anytime soon and this affects enough sites/users to be considered for a merge.

@wonderboymusic Can you have another look and commit if it makes sense?

#10 @swissspidy
4 years ago

  • Milestone changed from Awaiting Review to 4.4

#11 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35283:

Feeds: add CEST to $timezone in SimplePie_Parse_Date.

Props swissspidy.
Fixes #32749.

Note: See TracTickets for help on using tickets.