Opened 10 years ago
Closed 10 years ago
#32782 closed defect (bug) (fixed)
We have two different star ratings (again)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch |
Focuses: | ui, administration | Cc: |
Description
The star ratings on plugin install and theme details have diverged again, this time in both markup and color. It appears that we neglected to update the theme details one in #31424. I think the markup may necessarily need to be different as they are a PHP function and a JS template respectively, but we should at least consistently use the .star-rating
class - right now themes.css
has a woefully underqualified .rating
class that causes some side effects elsewhere (links, which people may not notice anymore, but it's still there).
Attachments (1)
Change History (4)
Note: See
TracTickets for help on using
tickets.
32782.diff is a fairly minimal change that doesn't try to normalize the actual markup besides the
.rating
class becoming.star-rating
. Also does some clean up for the full star CSS. I had to remove the spaces between the spans for theme ratings because they are visible and space the stars out more than in plugins. Now both look as plugins currently does. Some before shots of themes and plugins: