Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#32782 closed defect (bug) (fixed)

We have two different star ratings (again)

Reported by: helen's profile helen Owned by: obenland's profile obenland
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: ui, administration Cc:

Description

Previously: #20655, #31424.

The star ratings on plugin install and theme details have diverged again, this time in both markup and color. It appears that we neglected to update the theme details one in #31424. I think the markup may necessarily need to be different as they are a PHP function and a JS template respectively, but we should at least consistently use the .star-rating class - right now themes.css has a woefully underqualified .rating class that causes some side effects elsewhere (links, which people may not notice anymore, but it's still there).

Attachments (1)

32782.diff (4.0 KB) - added by helen 10 years ago.

Download all attachments as: .zip

Change History (4)

@helen
10 years ago

#1 @helen
10 years ago

  • Keywords has-patch added

32782.diff is a fairly minimal change that doesn't try to normalize the actual markup besides the .rating class becoming .star-rating. Also does some clean up for the full star CSS. I had to remove the spaces between the spans for theme ratings because they are visible and space the stars out more than in plugins. Now both look as plugins currently does. Some before shots of themes and plugins:

http://s.hyhs.me/blcP/image.png http://s.hyhs.me/blwX/image.png

This ticket was mentioned in Slack in #design by helen. View the logs.


10 years ago

#3 @obenland
10 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 33073:

Synchronize star ratings of themes and plugins.

Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.

Note: See TracTickets for help on using tickets.