Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32792 closed defect (bug) (fixed)

Media template better descriptive strings

Reported by: afercia's profile afercia Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: ui, accessibility Cc:


Splitting this out from #26550.

Some of the strings used for UI controls in /wp-includes/media-template.php should be clearly understandable even when read out of context. For example, when adding video or audio alternative sources or when adding a video poster image a UI control "Remove" appears. When read out of context it's not clear what this "Remove" refers to.

Please notice new strings were proposed in the first patch on 26550 but then agreed to handle them in a separate ticket for convenience and readability of the patch.

Attachments (2)

32792.patch (2.9 KB) - added by afercia 9 years ago.
32792.2.patch (688 bytes) - added by afercia 9 years ago.
Remove context for video track

Download all attachments as: .zip

Change History (8)

9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch commit added; needs-patch removed

In the proposed patch:

  • Media modal: use better descriptive text for the "Remove" source, "Remove" poster image, "Remove" track, buttons.

See screenshot before/after:

#2 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 32972:

Media modal: Use better descriptive text for "Remove" buttons.

props afercia.
fixes #32792.

#3 @ocean90
9 years ago

Do we still need the context "media" for "Remove video track"? I don't think so.

9 years ago

Remove context for video track

#4 @afercia
9 years ago

@ocean90: there you go :)

#5 @pavelevap
9 years ago

Nobody cares about closed tickets :-)

Anybody can commit second patch?

And one more accessibility question: "Remove ... source" is displayed also when there is only one source available? It should not be possible to remove primary (only) source, because there is broken shortcode in the end...

#6 @afercia
9 years ago

@pavelevap thanks :) we shouldn't re-open a ticket that was closed on a fixed milestone. Do you mind creating a new ticket referencing this one?

Note: See TracTickets for help on using tickets.