Dashboard feeds when switching language

[andg]

This might not be the most relevant thing to cover, since language selection is now done at the beginning of the installation process, but when you switch from one language to another, dashboard News feeds should be refreshed in order to show localized content, and allow for the translation of the "Popular Plugin" string, without waiting for the transient to expire.

[ocean90]

Hello andg, welcome to Trac!

Thanks for your valid report.
The feed gets cached in wp_dashboard_cached_rss_widget() The current cache key in wp_dashboard_cached_rss_widget() is 'dash_' . md5( $widget_id ). I think we should change the cache key to include the current locale.
For the credits we're using 'wordpress_credits_' . $locale so we could change the key to 'dash_' . md5( $widget_id ) . '_' . $locale.

[andg]

That makes sense, as the feeds cached with the old key would automatically be updated with the new one with the new key, without the user noticing.

[johnbillion]

In 33183:

Append the current locale to dashboard RSS widget cache keys so they refresh accordingly when the locale is changed.

Fixes #32804
Props andg

[dd32]

As the maximum length of an expiring transient name is 45 characters, this will cause issue for any site which has their locale set to anything longer than 8 characters (45 - 5 (dash_) - 32 (md5) = 8)

Although most locale's are 5~6 characters max, there's things like de_DE_formal and 58 other locale variants that are showing up in the WordPress.org stats which are longer than 8 characters.

[andg]

Thanks @dd32. So, this solution ain't gonna work. Perhaps we could simply leave the transient name as it is right now, track when language switching happens and manually trigger a Dashboard feed refresh by deleting that transient. Is that possible?

[ocean90]

We can move the locale inside md5().

[andg]

This is a new version of the patch with the solution proposed by @ocean90 to include the locale inside the md5 call.

[johnbillion]

Ugh, I considered the length of the transient key but not the transient timeout key. My bad.

32804.diff​ makes sense.

[dd32]

32804.diff​ makes sense.

Seems fine to me too.

[johnbillion]

In 33192:

Place the locale inside the md5 hash in the dashboard RSS feed widget transient key to prevent the transient timeout option name becoming longer than the allowed field size.

Props andg
Fixes #32804

[SergeyBiryukov]

In 40802:

Dashboard: Append the current locale to dashboard RSS widget cache key in wp_dashboard_rss_control(), for consistency with the changes to wp_dashboard_cached_rss_widget() in [33183] and [33192].

See #32804, #40702.