<audio><video>tags not closed properly

[patilswapnilv]

The <audio> and <video> tags are not closed properly in the media-template.php file in wp-includes.

line no. 19, 811 and 91

<audio style="visibility: hidden"
	controls
	class="wp-audio-shortcode"
	width="{{ _.isUndefined( data.model.width ) ? 400 : data.model.width }}"
	preload="{{ _.isUndefined( data.model.preload ) ? 'none' : data.model.preload }}"
	<#
	<?php foreach ( array( 'autoplay', 'loop' ) as $attr ):
	?>if ( ! _.isUndefined( data.model.<?php echo $attr ?> ) && data.model.<?php echo $attr ?> ) {
		#> <?php echo $attr ?><#
	}
	<?php endforeach ?>#>
>
	<# if ( ! _.isEmpty( data.model.src ) ) { #>
	<source src="{{ data.model.src }}" type="{{ wp.media.view.settings.embedMimes[ data.model.src.split('.').pop() ] }}" />
	<# } #>

	<?php foreach ( $audio_types as $type ):
	?><# if ( ! _.isEmpty( data.model.<?php echo $type ?> ) ) { #>
	<source src="{{ data.model.<?php echo $type ?> }}" type="{{ wp.media.view.settings.embedMimes[ '<?php echo $type ?>' ] }}" />
	<# } #>
	<?php endforeach;
?></audio>

though the tag is closed later on line 43, I think that is not the correct way.

[dd32]

Link to source: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/media-template.php#L16

Hi @patilswapnilv, can you explain what the actual problem is here? The tags appear to be closed correctly. Note: The <source> tags must be within the <audio>...</audio> tags.

[patilswapnilv]

I am really sorry, I just missed the closing tag on the line no. 30.