WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32808 closed enhancement (fixed)

Add a Manage in Customizer link to the menus admin

Reported by: celloexpressions Owned by: jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-screenshots
Focuses: ui Cc:
PR Number:

Description

To match what we have for widgets, for discover-ability.

This was patched on the tracking ticket, but splitting out here so it doesn't get missed.

Attachments (14)

32808.diff (1014 bytes) - added by celloexpressions 4 years ago.
32808-panel.patch (593 bytes) - added by swissspidy 4 years ago.
Fix panel parameter
image.jpg (211.6 KB) - added by ryan 4 years ago.
Screen Shot 2015-06-30 at 3.16.57 PM.png (496.6 KB) - added by ryan 4 years ago.
32808.2.diff (886 bytes) - added by obenland 4 years ago.
Screen Shot 2015-07-01 at 12.50.03 PM.png (25.5 KB) - added by obenland 4 years ago.
Screen Shot 2015-07-01 at 12.50.13 PM.png (29.2 KB) - added by obenland 4 years ago.
Screen Shot 2015-07-01 at 12.52.21 PM.png (24.8 KB) - added by obenland 4 years ago.
Just with preventing wrapping.
image.2.jpg (208.5 KB) - added by ryan 4 years ago.
iPhone 6+
custom-header-manage-in-customize.png (56.4 KB) - added by celloexpressions 4 years ago.
Manage in Customizer link on custom header (and background) admin page.
32808.3.diff (2.0 KB) - added by jeremyfelt 4 years ago.
Screen Shot 2015-07-21 at 3.35.48 PM.png (32.8 KB) - added by jeremyfelt 4 years ago.
after-32808.3.diff-large.png (83.5 KB) - added by jeremyfelt 4 years ago.
Large view after pending commit of 32808.3.diff
after-32808.3.diff-mobile.png (49.8 KB) - added by jeremyfelt 4 years ago.
Mobile view after pending commit of 32808.3.diff

Download all attachments as: .zip

Change History (42)

#1 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 32985:

Menus: Add a Manage in Customizer link, like we did for Widgets screen in [30459].

props celloexpressions.
fixes #32808.

#2 @swissspidy
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The link points to the wrong panel so it doesn't focus on the nav menu panel.

@swissspidy
4 years ago

Fix panel parameter

#3 @rabmalin
4 years ago

#32836 was marked as a duplicate.

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


4 years ago

#5 @obenland
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 33004:

Use correct panel id for menus when linking to the customizer.

Props swissspidy.
Fixes #32808.

#6 @ryan
4 years ago

  • Keywords needs-screenshots added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

@ryan
4 years ago

#7 @ryan
4 years ago

This is one reason why I want desktop and mobile screenshots to be commit requirements.

This ticket was mentioned in Slack in #core-flow by boren. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by obenland. View the logs.


4 years ago

@obenland
4 years ago

#10 @obenland
4 years ago

  • Keywords needs-screenshots removed

Patch makes it look like another tab on mobile.

We could just prevent it from wrapping but that doesn't really look very elegant.
@helen, what do you think?

@obenland
4 years ago

Just with preventing wrapping.

This ticket was mentioned in Slack in #core by obenland. View the logs.


4 years ago

#12 @obenland
4 years ago

Per discussion with @hugobaeta in Slack (see above), we'll go for the small solution.

#13 @obenland
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 33040:

Prevent link to customizer from wrpping on small screens.

Fixes #32808.

This ticket was mentioned in Slack in #core-customize by paulwilde. View the logs.


4 years ago

#15 @jeremyfelt
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Is there a way we can break this out above the Edit Menus and Manage Locations tabs on mobile? It still looks very broken in its current state. I'm hoping to translate this pattern to a patch on #32525 as well.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


4 years ago

#17 @ryan
4 years ago

  • Keywords needs-screenshots added

#18 @obenland
4 years ago

  • Owner changed from SergeyBiryukov to jeremyfelt
  • Status changed from reopened to assigned

@ryan
4 years ago

iPhone 6+

This ticket was mentioned in Slack in #design by helen. View the logs.


4 years ago

@celloexpressions
4 years ago

Manage in Customizer link on custom header (and background) admin page.

#20 @celloexpressions
4 years ago

  • Keywords needs-patch added

Current status here looks like we're trying to figure out a better styling for these links, but without much success so far. I'd like this to be a persistent link, because users may land on these screens and mean to go to the Customizer instead, so a dismiss-able notice probably won't work. A more subtle link that initially has a dismiss-able feature pointer could work though.

I added a screenshot of the custom header admin page. It, and the custom background page, still exist, primarily for no-js users, but they aren't linked anywhere in core anymore for users that can access the Customizer. On those screens, we have the info-style notice with a descriptive sentence that links to the Customizer version. I think we went with the alternate styling for widgets to be less invasive, but I do think that this is probably the most appropriate way to include a link to the Customizer version on the admin screens, especially promoting the ability to live-preview changes.

See #28032 for more history.

Also just got another idea - what if when the Customize admin bar link is present in the admin, when on this screen we deep-link it to menus? Make it contextual to the current admin context when possible, like it's contextual to the current front-end context.

#21 follow-up: @obenland
4 years ago

@jeremyfelt, any news here? Should we tackle that as an enhancement in 4.4 maybe?

#22 in reply to: ↑ 21 @jeremyfelt
4 years ago

Replying to obenland:

@jeremyfelt, any news here? Should we tackle that as an enhancement in 4.4 maybe?

There was some discussion in #design a bit ago, but I don't think any consensus. #32525 went a different route with a couple text links rather than a button.

I'd prefer leaving this open until a design decision is made. If we do need to postpone it to 4.4, we should hide "Manage in Customizer" on mobile as it looks really out of place.

I'll bring it up in #core-customizer and #design tomorrow and see if there are new thoughts.

#23 @obenland
4 years ago

@hugobaeta, could you weigh in on this as well?

#24 @obenland
4 years ago

Hiding it on mobile would work for me too.

@jeremyfelt
4 years ago

#25 @jeremyfelt
4 years ago

  • Keywords ui-feedback added

32808.3.diff adds an <h1>Menus... to match the other admin screens and then places "Manage in Customizer" alongside it. This follows the pattern from Widgets, but still feels really weird. It does translate to mobile though.

The H1 for this page is then "Menus Manage in Customizer". The H1 for Widgets is "Widgets Manage in Customizer".

This ticket was mentioned in Slack in #design by jeremyfelt. View the logs.


4 years ago

@jeremyfelt
4 years ago

Large view after pending commit of 32808.3.diff

@jeremyfelt
4 years ago

Mobile view after pending commit of 32808.3.diff

#27 @jeremyfelt
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33355:

Nav Menus: Add a Menus title with Manage in Customizer button to nav-menus.php

This aligns the <h1> on wp-admin/nav-menus.php with that of other admin screens and aligns the "Manage in Customizer" button with that on wp-admin/widgets.php.

Fixes #32808.

#28 @jeremyfelt
4 years ago

  • Keywords has-screenshots added; needs-screenshots needs-patch ui-feedback removed

See #26601 as a ticket for future improvements to <h1> titles on these admin pages.

Note: See TracTickets for help on using tickets.