WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#32811 closed defect (bug) (fixed)

Customizer Menus: Reorder Done button should not be in red

Reported by: akibjorklund Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch ui-feedback
Focuses: ui Cc:

Description

Red indicates the button would cancel what I have just done to me, but that is not what the done button does. Maybe use the blue link color instead – though this is not a link and probably should look more like a button.

Attachments (5)

32811.diff (354 bytes) - added by Kau-Boy 6 years ago.
before.png (14.3 KB) - added by obenland 6 years ago.
after.png (14.2 KB) - added by obenland 6 years ago.
blue_after.png (14.6 KB) - added by obenland 6 years ago.
32811.2.diff (493 bytes) - added by obenland 6 years ago.
Blue

Download all attachments as: .zip

Change History (10)

#1 @Kau-Boy
6 years ago

  • Keywords has-patch added

I agree that red is not a good color for what the link is doing. I would simply not set any new color to the link and keep it gray.

Patch created on the #wceu contributor day.

Last edited 6 years ago by Kau-Boy (previous) (diff)

@Kau-Boy
6 years ago

#2 @celloexpressions
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.3

Looks good to me.

@obenland
6 years ago

@obenland
6 years ago

@obenland
6 years ago

@obenland
6 years ago

Blue

#3 @obenland
6 years ago

  • Keywords ui-feedback added; commit removed

I almost like the blue better.

Worth noting: This is also used in Widgets.

#4 @melchoyce
6 years ago

The grey "Done" doesn't look clickable. I'd go for the blue.

#5 @obenland
6 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 33012:

Customizer: Fresh colors for Reorder Done button.

When reordering Widgets or Menus, the red colorcould suggest
it would cancel the changes, rather than save them. The blue
suggests it's clickable and is more in line with the Close
link on open Widgets.

Fixes #32811.

Note: See TracTickets for help on using tickets.