#32813 closed defect (bug) (fixed)
Customizer Menus: Focus style of Edit Menu Item arrow overlaps with item type label
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
Narrowing the open/close button a few pixels would solve the issue.
Attachments (4)
Change History (15)
#3
@
10 years ago
I didn't saw the previous patch before I attached mine - some strange caching issue maybe? But in my patch I'm using 25px
, because 20px
are not enough for me.
#4
follow-up:
↓ 5
@
10 years ago
The more the padding is, the less the space for menu item label, so probably we should stick to something like in between 20 and 25 pixels?
#5
in reply to:
↑ 4
@
10 years ago
Replying to andg:
The more the padding is, the less the space for menu item label, so probably we should stick to something like in between 20 and 25 pixels?
I agree. The first time when I tested it with 20px the space wasn't enough (for me) and that's why I used 25px. Something like 22-23px maybe would be enough to fix the issue and leave enough space for menu item label.
#6
@
10 years ago
- Milestone changed from Awaiting Review to 4.3
Screenshots, please. Would like to keep it as square-looking/centered as possible while avoiding overlap.
This ticket was mentioned in Slack in #core by jorbin. View the logs.
10 years ago
#9
@
10 years ago
Just a note that you don't need to patch the RTL versions, as they are built. If you aren't patching from the src directory in the develop repo, also consider moving to that.
Related: #32771