Avoid HTML tags in translation strings (WP_Customize_Themes_Section)

[henrikakselsen]

I have setup the translation to only evaluate the text, not the html tags.

[henrikakselsen]

Only translate text portion of strings

[GaryJ]

Hi @henrikakselsen, thanks for submitting your first report and patch!

A couple of points:

• The first pair of echo have got a pair of () around the content - these are not needed and should be removed.
• Instead of using . to echo, you can use ,, which has a slight performance benefit, as it echos the values straight away, instead of building up into a single string first.

If you do a new patch, just upload it as the same name (leave the existing one there for historical reference), and Trac will append a suffix so that it becomes a new file name.

[henrikakselsen]

Fix echo command for best practices

[henrikakselsen]

Thank you Gary. I rerolled the patch now.

[celloexpressions]

I've never seen , as opposed to . used in core, but I'm not personally opposed. This looks like it should be fine for 4.3 if it gets committed in a reasonably timely manner. Only possible issue would be if you wanted to move the theme placeholder, but not sure that that would be needed (this isn't my area of expertise).

[obenland]

We need the placeholder for RTL languages to be able to shift that value around.
Generally it should be avoided to use HTML in translation strings, but things like a single anchor or scenarios like this are exceptions to that rule.

[SergeyBiryukov]

Replying to obenland:

We need the placeholder for RTL languages to be able to shift that value around.

.customize-action is a block element, so there's no need to move the placeholder here: 32817.rtl.png​.

Generally, I don't think RTL languages have to shift placeholders often, text direction should take care of that.

Replying to GaryJ:

Instead of using . to echo, you can use ,, which has a slight performance benefit, as it echos the values straight away, instead of building up into a single string first.

I'd suggest leaving this discussion for #31950 and using concatenation for now for consistency with other core files.

[ocean90]

I agree that it's safe to remove the placeholder here. We should do the same in WP_Customize_Themes_Section::render().

[SergeyBiryukov]

Replying to ocean90:

We should do the same in WP_Customize_Themes_Section::render().

The patch is for WP_Customize_Themes_Section::render(). Did you mean any other class?

[SergeyBiryukov]

In 33078:

Customizer: Remove HTML tags from two translatable strings.

props henrikakselsen.
fixes #32817.