Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#32825 closed defect (bug) (fixed)

List table checkbox column positioning wrong for long column names

Reported by: daniluk4000 Owned by: SergeyBiryukov
Priority: normal Milestone: 4.4
Component: Administration Version: 4.2.2
Severity: normal Keywords: has-patch commit has-screenshots
Cc: Focuses: ui

Description

Too big posts header in all languages. That's why checkbox is not in position that is should be... Really don't know how to fix it and maybe it dublicate...

Attachments (4)

bug.png (6.4 KB ) - added by daniluk4000 11 years ago.
32825.patch (832 bytes ) - added by swissspidy 11 years ago.
32825.png (103.1 KB ) - added by swissspidy 11 years ago.
IMG_4718.PNG (192.4 KB ) - added by ryan 11 years ago.
After, iPhone 6+, looks good

Download all attachments as: .zip

Change History (20)

@daniluk4000
11 years ago

#1 @swissspidy
11 years ago

@daniluk4000: Can you test this with the latest development version (trunk)? I think there were some recent changes regarding the positioning of these headers.

#2 @daniluk4000
11 years ago

  • Keywords needs-patch added

@swissspidy using build 32991 and same error, I don't think that build 32997 can fix it ...

Version 0, edited 11 years ago by daniluk4000 (next)

#3 @daniluk4000
11 years ago

  • Component Posts, Post TypesGeneral
  • Focuses ui added
  • Summary Space in posts header.manage-column checkbox

UPDATE: this bug appends for all .manage-column

This ticket was mentioned in Slack in #core by daniluk4000. View the logs.


11 years ago

This ticket was mentioned in Slack in #core by daniluk4000. View the logs.


11 years ago

This ticket was mentioned in Slack in #core by daniluk4000. View the logs.


11 years ago

#7 @SergeyBiryukov
11 years ago

  • Component GeneralPosts, Post Types
  • Focuses administration added

@swissspidy
11 years ago

#8 @swissspidy
11 years ago

  • Keywords has-patch added; needs-patch removed

The attached patch fixes the checkbox alignment by using vertical-align. Works on smaller screens and bigger screens alike, no matter how long the table headings are.

This ticket was mentioned in Slack in #design by daniluk4000. View the logs.


11 years ago

This ticket was mentioned in Slack in #core by daniluk4000. View the logs.


11 years ago

#11 @swissspidy
11 years ago

  • Keywords needs-screenshots added

@swissspidy
11 years ago

#12 @swissspidy
11 years ago

  • Component Posts, Post TypesAdministration
  • Focuses administration removed
  • Keywords needs-screenshots removed
  • Milestone Awaiting Review4.4
  • Summary .manage-column checkboxList table checkbox column positioning wrong for long column names

Patch still applies. 32825.png shows how the checkbox in the table header looks like with the fix applied.

Without the patch, the checkbox is aligned to the top, which looks a bit off when using WordPress in another language with has longer column names (see bug.png). Same with plugins.

IMHO a good candidate for 4.4.

This ticket was mentioned in Slack in #core by sergey. View the logs.


11 years ago

#14 @SergeyBiryukov
11 years ago

  • Keywords commit added

#15 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 33928:

List tables: Adjust the styles for checkbox column to align better with longer column names.

Props swissspidy.
Fixes #32825.

#16 @ryan
11 years ago

  • Keywords has-screenshots added

@ryan
11 years ago

After, iPhone 6+, looks good

Note: See TracTickets for help on using tickets.