WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#32847 closed enhancement (fixed)

Remove 'error' parameter in wp_admin_canonical_url()

Reported by: jdgrimes's profile jdgrimes Owned by: johnbillion's profile johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: needs-patch
Focuses: administration Cc:

Description

wp_admin_canonical_url() was introduced in #23367 ([31736]). It removes a bunch of query parameters, but not error. However, error is used on the widgets and themes screens. Is there any reason that it shouldn't be removed as well?

Change History (4)

#1 follow-up: @johnbillion
8 years ago

  • Keywords needs-patch reporter-feedback added
  • Milestone changed from Awaiting Review to Future Release

Makes sense for the widgets screen. When/where is error used on the themes screen? I can't seem to see it.

See also #32692

#2 in reply to: ↑ 1 @jdgrimes
8 years ago

  • Keywords reporter-feedback removed

Replying to johnbillion:

When/where is error used on the themes screen? I can't seem to see it.

I just realized that it was /network/themes.php. See lines 294-6. Also on /network/site-themes.php line 177.

I just noticed that site-themes.php cleans the URI though. So does /network/themes.php.

#3 @johnbillion
8 years ago

  • Milestone changed from Future Release to 4.4

#4 @johnbillion
8 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 33770:

Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url().

Fixes #32847

Note: See TracTickets for help on using tickets.