WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#32847 closed enhancement (fixed)

Remove 'error' parameter in wp_admin_canonical_url()

Reported by: jdgrimes Owned by: johnbillion
Priority: normal Milestone: 4.4
Component: Administration Version: 4.2
Severity: normal Keywords: needs-patch
Cc: Focuses: administration

Description

wp_admin_canonical_url() was introduced in #23367 ([31736]). It removes a bunch of query parameters, but not error. However, error is used on the widgets and themes screens. Is there any reason that it shouldn't be removed as well?

Change History (4)

#1 follow-up: @johnbillion
11 years ago

  • Keywords needs-patch reporter-feedback added
  • Milestone Awaiting Review → Future Release

Makes sense for the widgets screen. When/where is error used on the themes screen? I can't seem to see it.

See also #32692

#2 in reply to: ↑ 1 @jdgrimes
11 years ago

  • Keywords reporter-feedback removed

Replying to johnbillion:

When/where is error used on the themes screen? I can't seem to see it.

I just realized that it was /network/themes.php. See lines 294-6. Also on /network/site-themes.php line 177.

I just noticed that site-themes.php cleans the URI though. So does /network/themes.php.

#3 @johnbillion
11 years ago

  • Milestone Future Release → 4.4

#4 @johnbillion
11 years ago

  • Owner set to johnbillion
  • Resolution → fixed
  • Status new → closed

In 33770:

Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url().

Fixes #32847

Note: See TracTickets for help on using tickets.