wpColorPicker close should check that iris hasn't been destroyed before toggling it.

[gitlost]

wpColorPicker.close() can be called (via the 'click.wpcolorpicker' event on body) when the internally used iris widget has already been destroyed, which means that when it attempts to toggle iris an exception is thrown. The attached patch just checks that iris still exists before the toggle is attempted.

This issue arose in response to the question "Modify Custom Field in Media Library using JavaScript" by @Howdy_McGee on Wordpress Development stackexchange ​http://wordpress.stackexchange.com/questions/193006/modify-custom-field-in-media-library-using-javascript, which can be used to replicate the scenario. If you open the color picker and then, leaving it open, close the Attachment Details modal window, a $.error exception is thrown (or can be - may depend on your system) by jQuery UI Widget, "cannot call methods on iris prior to initialization".

[gitlost]

In close() check iris exists before attempting to toggle it.

[gitlost]

Still good for 4.4.

[arpowers]

I have the same issue, however, i think we also need to add this same check to the 'open()' function as well inside the colorPicker.

[arpowers]

Never mind, i indeed had the same bug. Same fix works, i can't believe it (2 hours later)

[gitlost]

Refresh with unittest.