Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#32857 closed defect (bug) (fixed)

In menu customizer: sortable placeholder not correctly accounting for children height when doing drag and drop

Reported by: adamsilverstein's profile adamsilverstein Owned by: adamsilverstein's profile adamsilverstein
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch dev-feedback commit
Focuses: Cc:


When dragging and dropping a menu with subitems, the placeholder size is not being correctly calculated. No matter how many subitems exist, the placeholder is always one item high.

I tracked this down to the left hand alignment we use for li items in the customizer layout. removing this just for the placeholder lis resolves the issue.

Here is what dragging with children currently looks like:

Here is the same action with the CSS change (patch incoming):

Attachments (1)

32857.diff (370 bytes) - added by adamsilverstein 9 years ago.
Fix a sortable placeholder height issue

Download all attachments as: .zip

Change History (5)

9 years ago

Fix a sortable placeholder height issue

#1 @adamsilverstein
9 years ago

  • Keywords has-patch dev-feedback commit added
  • Owner set to adamsilverstein
  • Status changed from new to assigned

In 32857.diff:

  • Set float: to none for placeholder child li tags, correcting an issue where the placeholder height was always only one item height. After this patch the placeholder size correctly matches the size of the dragged item plus all children.

This ticket was mentioned in Slack in #core-customize by adamsilverstein. View the logs.

9 years ago

#3 @obenland
9 years ago

  • Milestone changed from Awaiting Review to 4.3

#4 @ocean90
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33028:

Customizer: Fix height calculation of placeholders when dragging menu items.

props adamsilverstein.
fixes #32857.

Note: See TracTickets for help on using tickets.