WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#32860 closed defect (bug) (fixed)

Site icon media modal has wrong date dropdown

Reported by: pavelevap Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: General Keywords: has-patch
Focuses: javascript Cc:

Description

See attached screenshot.

Attachments (4)

Site_icon_wrong_date_dropdown.png (44.8 KB) - added by pavelevap 3 years ago.
32860.patch (1.3 KB) - added by ocean90 3 years ago.
32860.diff (3.9 KB) - added by obenland 3 years ago.
32860.2.diff (4.8 KB) - added by obenland 3 years ago.

Download all attachments as: .zip

Change History (7)

@ocean90
3 years ago

#1 @ocean90
3 years ago

  • Focuses javascript added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.3

32860.patch is a first pass. It allows also to set suggestedWidth and suggestedHeight.

@obenland
3 years ago

@obenland
3 years ago

#2 @obenland
3 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 33075:

Site Icon: Remove date dropdown from media modal.

This also allows us to leverage the builtin suggestedWidth and
suggestedHeight parameters to convey the expected image size.

Props ocean90.
Fixes #32860.

#3 @obenland
3 years ago

#32890 was marked as a duplicate.

Note: See TracTickets for help on using tickets.