WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 7 months ago

#32861 reopened enhancement

Site Icon: Provide display for all existing site-icon cropped images

Reported by: pavelevap Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: needs-patch
Focuses: ui, administration Cc:

Description

Example:

I had a picture and tried to set it up as site icon. I cropped this image and now I have cropped-image.png variant of this image 512 x 512 px. Then I tried other images and in the end I wanted to go with the first one. But when I selected this cropped image, I had to crop it once again even if right dimensions. So, now there is another cropped-cropped-image.png image in media library and it does not make sense...

Also images for site icons should be somehow marked (as for header images in Customizer). How can I find my cropped images for site icon in media library when trying to set up site icon?

Change History (9)

#1 @kraftbj
22 months ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #16434.

I noticed this too. I'm going to mark this as a duplicate of 16434 since it was brought up with a proposed patch over at https://core.trac.wordpress.org/ticket/16434#comment:194

If it doesn't make it into 4.3 (or the powers that be decide), we can reopen this to track this issue specifically.

#2 follow-up: @pavelevap
22 months ago

OK, it should make into 4.3 because it is not very good user experience.

And what about the second part? Showing all images cropped for site icon? And what about setting site icon in Customizer? We can reopen this ticket (and rename it a little)?

#3 in reply to: ↑ 2 @kraftbj
22 months ago

  • Component changed from General to Customize
  • Focuses ui administration added
  • Resolution duplicate deleted
  • Status changed from closed to reopened
  • Summary changed from Site icon image forced to crop even if right dimensions to Site Icon: Provide display for all existing site-icon cropped images
  • Type changed from defect (bug) to enhancement

Replying to pavelevap:

And what about the second part? Showing all images cropped for site icon? And what about setting site icon in Customizer? We can reopen this ticket (and rename it a little)?

Sorry about that—honestly glossed right over it once I saw the connection to the existing chatter on the other ticket. I'm just a regular chum around here, but yeah, makes sense to me to reopen/change title for the second point. This may be already on-deck for the Customizer version of the setting, but I'm not sure.

To restate: Provide an UI to see all images previously uploaded as a site icon for easier selection of an existing cropped icon, akin to header images in the Customizer.

#4 @celloexpressions
22 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

In the Customizer, I'm trying to design the cropped-image control (which site icons is based on) so that an option can be added to it in the future that shows all images previously uploaded to/cropped to the specific control (see #29211). Like header images have.

I'm not sure whether this would be viable in the settings version, but I think we can do this in the Customizer at some point.

#5 follow-up: @QROkes
16 months ago

When you upload a exact size (512x512) image for site icon, WP generate a cropped versión even when it has the right dimensions, this is not good for UX.
If you change the site icon and then you choose again the same image you used before, WP generate another cropped versión of the same image.
If you frequently change your icon or you're just testing some images for site icon, you end up with a ton of cropped versions of the same image.

#6 in reply to: ↑ 5 @Ov3rfly
16 months ago

Replying to QROkes:

When you upload a exact size (512x512) image for site icon, WP generate a cropped version even when it has the right dimensions ... you end up with a ton of cropped versions of the same image.

Same problem here.

Expected behaviour/suggestion: Site icon should not be cropped if image has 1:1 aspect ratio and user did no manual cropping.

#8 @celloexpressions
12 months ago

This should be possible to implement in the cropped image control as a library option. However, we need to figure out what the UI should look like. I don't think doing it inline like the header image control is appropriate. Rather, it should be part of the media modal (maybe a tab or something), or in some other slide-out panel that is shown after some initial interaction. Does anyone have ideas here?

This ticket was mentioned in Slack in #core-themes by celloexpressions. View the logs.


7 months ago

Note: See TracTickets for help on using tickets.