Site Icon: Provide display for all existing site-icon cropped images

[pavelevap]

Example:

I had a picture and tried to set it up as site icon. I cropped this image and now I have cropped-image.png variant of this image 512 x 512 px. Then I tried other images and in the end I wanted to go with the first one. But when I selected this cropped image, I had to crop it once again even if right dimensions. So, now there is another cropped-cropped-image.png image in media library and it does not make sense...

Also images for site icons should be somehow marked (as for header images in Customizer). How can I find my cropped images for site icon in media library when trying to set up site icon?

[kraftbj]

Duplicate of #16434.

I noticed this too. I'm going to mark this as a duplicate of 16434 since it was brought up with a proposed patch over at https://core.trac.wordpress.org/ticket/16434#comment:194

If it doesn't make it into 4.3 (or the powers that be decide), we can reopen this to track this issue specifically.

[pavelevap]

OK, it should make into 4.3 because it is not very good user experience.

And what about the second part? Showing all images cropped for site icon? And what about setting site icon in Customizer? We can reopen this ticket (and rename it a little)?

[kraftbj]

Replying to pavelevap:

And what about the second part? Showing all images cropped for site icon? And what about setting site icon in Customizer? We can reopen this ticket (and rename it a little)?

Sorry about that—honestly glossed right over it once I saw the connection to the existing chatter on the other ticket. I'm just a regular chum around here, but yeah, makes sense to me to reopen/change title for the second point. This may be already on-deck for the Customizer version of the setting, but I'm not sure.

To restate: Provide an UI to see all images previously uploaded as a site icon for easier selection of an existing cropped icon, akin to header images in the Customizer.

[celloexpressions]

In the Customizer, I'm trying to design the cropped-image control (which site icons is based on) so that an option can be added to it in the future that shows all images previously uploaded to/cropped to the specific control (see #29211). Like header images have.

I'm not sure whether this would be viable in the settings version, but I think we can do this in the Customizer at some point.

[anonymized_14169293]

When you upload a exact size (512x512) image for site icon, WP generate a cropped versión even when it has the right dimensions, this is not good for UX.
If you change the site icon and then you choose again the same image you used before, WP generate another cropped versión of the same image.
If you frequently change your icon or you're just testing some images for site icon, you end up with a ton of cropped versions of the same image.

[Ov3rfly]

Replying to QROkes:

When you upload a exact size (512x512) image for site icon, WP generate a cropped version even when it has the right dimensions ... you end up with a ton of cropped versions of the same image.

Same problem here.

Expected behaviour/suggestion: Site icon should not be cropped if image has 1:1 aspect ratio and user did no manual cropping.

[celloexpressions]

Related: #36581.

[celloexpressions]

This should be possible to implement in the cropped image control as a library option. However, we need to figure out what the UI should look like. I don't think doing it inline like the header image control is appropriate. Rather, it should be part of the media modal (maybe a tab or something), or in some other slide-out panel that is shown after some initial interaction. Does anyone have ideas here?

[celloexpressions]

My latest comment still stands. This needs a design, and then a patch for WP_Customize_Cropped_Image_Control and any core instances where the library options would be useful. WP_Customize_Header_Image_Control (dates to WordPress 3.4) could then be replaced by the newer cropped-image control (dates to WordPress 4.1), which has been the plan for some time now. Plugins could also make use of this feature based on that implementation.

Replying to celloexpressions:

This should be possible to implement in the cropped image control as a library option. However, we need to figure out what the UI should look like. I don't think doing it inline like the header image control is appropriate. Rather, it should be part of the media modal (maybe a tab or something), or in some other slide-out panel that is shown after some initial interaction. Does anyone have ideas here?