WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #32878, comment 1


Ignore:
Timestamp:
07/15/2015 06:17:40 PM (9 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32878, comment 1

    initial v1  
    11The patch looks good. We can also make pretty much all groups non-capturing as they are only used to check if matches exist.
    22
    3 We can probably combine `/\/([^\.\/]+[-_]{1})?(spinner|loading|spacer|blank)s?([-_]{1}[^\.\/]+)?\.[a-z0-9]{3,4}/` and `/\/(spinner|loading|spacer|blank|rss)\.(gif|jpg|png)/`, as they are pretty close (assuming `\.[a-z0-9]{3,4}` is to match image extensions).
     3We can probably combine `!/([^./]+[-_])?(spinner|loading|spacer|blank)s?([-_][^./]+)?\.[a-z0-9]{3,4}!i` and `!/(spinner|loading|spacer|blank|rss)\.(gif|jpg|png)!i`, as they are pretty close (assuming `\.[a-z0-9]{3,4}` is to match image extensions).