Customizer search Widgets events

[afercia]

The events to trigger a search in the available Widgets in api.Widgets.AvailableWidgetsPanelView.events should be paired with what was done for the available Menu Items search, see 32824

See https://core.trac.wordpress.org/ticket/26600#comment:59 for some background.

[valendesigns]

I'll pick this one up tomorrow.

[valendesigns]

Actually, I'll work on this early 4.4 as this is technically an enhancement and not a bug from what I can tell.

[afercia]

Related: #32768.

[afercia]

There's now a new pattern in core which uses feature detection to determine whether inputs should use the keyup or input event, see [34078] and [36379]. As I see it, this should become standard.

if ( 'oninput' in document.createElement( 'input' ) ) {
	inputEvent = 'input';
} else {
	inputEvent = 'keyup';
}

Any chance to see some progress here? :) cc @ocean90

[dlh]

Since the last comments here, the Customizer has dropped support for IE 8. As I understand https://core.trac.wordpress.org/ticket/26600#comment:59 and other similar discussions (e.g. #38021), IE 8 support was the only reason to continue using keyup, so 32882.diff​ removes it.

[afercia]

Thanks @dlh ! @westonruter at this point maybe the keyup event can be removed from api.Menus.AvailableMenuItemsPanelView.events too?

[afercia]

Right. keyup was there only to support IE 8. 32882.2.diff​ refreshes the previous patch and also removes the keyup event used in the cases mentioned above:

• from api.Menus.AvailableMenuItemsPanelView.events
• the one used in [34078] (together with the feature detection bit)
• the one used in [36379] (together with the feature detection bit)

[pento]

32882.2.diff​ is good to commit.

[pento]

In 44539:

Admin: Don't use the keyup event in addition to the input event.

The keyup event was used to provide support for IE8, where which doesn't support the input event. As we dropped IE8 support some time ago, this was simply adding unnecessary complexity and double-event triggers.

Props dlh, afercia.
Fixes #32882.