WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 11 months ago

#32882 reviewing enhancement

Customizer search Widgets events

Reported by: afercia Owned by: afercia
Milestone: Future Release Priority: normal
Severity: normal Version: 4.2
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Description

The events to trigger a search in the available Widgets in api.Widgets.AvailableWidgetsPanelView.events should be paired with what was done for the available Menu Items search, see 32824

See https://core.trac.wordpress.org/ticket/26600#comment:59 for some background.

Attachments (1)

32882.diff (451 bytes) - added by dlh 11 months ago.

Download all attachments as: .zip

Change History (10)

#1 @valendesigns
2 years ago

  • Owner set to valendesigns
  • Status changed from new to assigned

I'll pick this one up tomorrow.

#2 @valendesigns
2 years ago

  • Type changed from defect (bug) to enhancement

Actually, I'll work on this early 4.4 as this is technically an enhancement and not a bug from what I can tell.

#3 @afercia
2 years ago

  • Keywords 4.4-early added

#4 @afercia
2 years ago

Related: #32768.

#5 @westonruter
2 years ago

  • Keywords 4.4-early removed

#6 @afercia
23 months ago

There's now a new pattern in core which uses feature detection to determine whether inputs should use the keyup or input event, see [34078] and [36379]. As I see it, this should become standard.

if ( 'oninput' in document.createElement( 'input' ) ) {
	inputEvent = 'input';
} else {
	inputEvent = 'keyup';
}

Any chance to see some progress here? :) cc @ocean90

@dlh
11 months ago

#7 @dlh
11 months ago

  • Keywords has-patch added; needs-patch removed

Since the last comments here, the Customizer has dropped support for IE 8. As I understand https://core.trac.wordpress.org/ticket/26600#comment:59 and other similar discussions (e.g. #38021), IE 8 support was the only reason to continue using keyup, so 32882.diff removes it.

#8 @westonruter
11 months ago

  • Owner changed from valendesigns to afercia
  • Status changed from assigned to reviewing

#9 @afercia
11 months ago

Thanks @dlh ! @westonruter at this point maybe the keyup event can be removed from api.Menus.AvailableMenuItemsPanelView.events too?

Note: See TracTickets for help on using tickets.