WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32905 closed defect (bug) (fixed)

Misaligned Select All checkbox on wp-admin/update-core.php

Reported by: ryan's profile ryan Owned by: ocean90's profile ocean90
Milestone: 4.3 Priority: low
Severity: normal Version: 4.3
Component: Upgrade/Install Keywords: has-patch needs-testing
Focuses: ui Cc:

Description

The Select All checkbox label is misaligned in both Firefox and Chrome on Macos. 4.3-beta1-33097

  • Visit the Grand Unified Updater at wp-admin/update-core.php with Firefox or Chrome on Macos.
  • Note the misaligned select all labels for the Plugins and Themes tables.

Attachments (6)

Screen Shot 2015-07-07 at 10.20.14 AM.png​ (497.0 KB) - added by ryan 9 years ago.
Firefox
Screen Shot 2015-07-07 at 10.20.17 AM.png​ (501.2 KB) - added by ryan 9 years ago.
Chrome
Screenshot 2015-07-07 11.41.21.png​ (20.2 KB) - added by kidsguide 9 years ago.
Internet Explorer
32905.diff​ (1.8 KB) - added by tywayne 9 years ago.
32905-after-mobile.png​ (113.4 KB) - added by ocean90 9 years ago.
32905-after.png​ (54.1 KB) - added by ocean90 9 years ago.

Download all attachments as: .zip

Change History (13)

@ryan
9 years ago

Firefox

@ryan
9 years ago

Chrome

#1 @kidsguide
9 years ago

#32906 was marked as a duplicate.

#2 @kidsguide
9 years ago

Found this same problem on Internet Explorer as well.

@kidsguide
9 years ago

Internet Explorer

#3 @ocean90
9 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.3
  • Priority changed from normal to low

@tywayne
9 years ago

#4 @tywayne
9 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

I think this is as simple as changing the markup in those tables. Looking at other list-tables elsewhere in the admin, they all have the select-all checkboxes in a <td> instead of <th> - Switching that out allows the correct styling to be applied.

#5 @ocean90
9 years ago

  • Owner set to ocean90
  • Status changed from new to accepted

@ocean90
9 years ago

@ocean90
9 years ago

#6 @ocean90
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33133:

Updates: Select All should not be a column header.

See #31654.

props tywayne.
fixes #32905.

This ticket was mentioned in ​Slack in #design by matthew. ​View the logs.
9 years ago

Note: See TracTickets for help on using tickets.