WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#32913 closed enhancement (fixed)

Improve network user searching

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch commit
Focuses: multisite Cc:

Description

Follow-up to #27304

On the Users screen in Network Admin, searching for users is a terrible experience. The user needs to be aware of the need to use a * wildcard character at the beginning and/or end of the search term, otherwise the search requires an exact match.

We should default to searching everything, all the time, as an extension to what we've just done in #27304.

Attachments (1)

32913.patch (710 bytes) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (6)

@johnbillion
4 years ago

#1 @johnbillion
4 years ago

  • Keywords has-patch added; needs-patch removed

32913.patch wraps the search term in asterisks in the same way that performing a user search on a single-site installation does.

This could have some performance concerns, but I think the same arguments presented in #27304 apply, in that being able to find users is much more important than the speed of the query.

#2 follow-up: @johnbillion
4 years ago

  • Keywords commit 2nd-opinion added
  • Milestone changed from Awaiting Review to 4.4

Any objections?

#3 in reply to: ↑ 2 @DrewAPicture
4 years ago

  • Keywords 2nd-opinion removed

Replying to johnbillion:

Any objections?

I think we should drop it in and it give a shot. Early enough in the cycle that any performance concerns should surface.

#4 @wonderboymusic
4 years ago

we have fast user queries somewhere?

#5 @johnbillion
4 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 33801:

Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.

Fixes #32913

Note: See TracTickets for help on using tickets.