Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32926 closed enhancement (invalid)

Twenty Twelve: Declaring WooCommerce Support

Reported by: danielsantoro's profile DanielSantoro Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.3
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Hey there!

I've been working as a WC support ninja for about a year and a half, and our go-to theme to test plugin conflicts or really anything is Twenty Twelve. It works wonderfully with WooCommerce and as far as I've seen has never given us any issues.

The one issue is that Twenty Twelve doesn't declare WooCommerce support. Occasionally, we'll have customers refuse to test with us because of the error message, and it delays resolution. Tiny little thing, but spread over a thousand times, it's an easy tweak.

The revision in the Gist here adds WooCommerce support with a few lines at the end of the theme functions: https://gist.github.com/DanielSantoro/bde3601e1c5b58b30f43/revisions

Hopefully we can sneak it into the next release. :)

Change History (3)

#1 @obenland
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hi Daniel,

Default themes can't play favoritism to certain plugins so they only declare support for core features, leaving support shims to the respective plugins. A good example would be Jetpack, which provides custom stylesheets for Infinite Scroll and other compat code to add support for some of its modules. I'd suggest to explore that route for WooCommerce as well.

#2 @kraftbj
9 years ago

Howdy @DanielSantoro -- for reference, this is how Jetpack does it:

https://github.com/Automattic/jetpack/blob/3.6/modules/theme-tools.php#L26-38

We check for the stylesheet or template and if it matches something in the array, we include that particular compat file.

#3 @georgestephanis
9 years ago

Also, this, in the case of infinitescroll --

https://github.com/Automattic/jetpack/blob/master/modules/infinite-scroll.php#L110-L137

If the file exists, we load it in.

Note: See TracTickets for help on using tickets.