WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 months ago

#32929 closed task (blessed) (fixed)

4.3 About page

Reported by: helen Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Help/About Keywords: has-patch
Focuses: Cc:

Description

Tracking ticket for this usual pre-release task.

Don't forget to sync changes over to credits.php and freedoms.php. :)

Attachments (12)

32929.diff (1.5 KB) - added by adamsilverstein 5 years ago.
32929.2.diff (6.9 KB) - added by ryelle 5 years ago.
about_4-3_pngs.zip (237.8 KB) - added by melchoyce 5 years ago.
32929.3.diff (2.2 KB) - added by obenland 5 years ago.
32929.4.diff (331 bytes) - added by melchoyce 5 years ago.
32929.5.diff (342 bytes) - added by melchoyce 5 years ago.
32929.6.diff (343 bytes) - added by melchoyce 5 years ago.
32929.7.diff (2.1 KB) - added by ocean90 5 years ago.
WP_List_Table
32929.8.diff (10.4 KB) - added by obenland 5 years ago.
32929.9.diff (10.5 KB) - added by obenland 5 years ago.
32929.10.diff (10.8 KB) - added by obenland 5 years ago.
32929.11.diff (700 bytes) - added by obenland 5 years ago.

Download all attachments as: .zip

Change History (49)

#1 @obenland
5 years ago

I chatted with a few contributors at WordCamp Europe about the About page. Someone had the idea (markjaquith possibly?) to not do one headline feature, but rather have a randomized grid of four features that we'd show. I really like that, it would spice things up a bit.

It would also be good to do a release video again. Something in the style of 3.6 maybe, yet still with a voiceover.

#2 @celloexpressions
5 years ago

@designsimply put together a really good video on menus in the Customizer in the merge proposal post; we may be able to reuse some ideas from there: https://make.wordpress.org/core/2015/06/03/feature-plugin-merge-proposal-menu-customizer/.

#3 @obenland
5 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#4 @obenland
5 years ago

In 33466:

About: First pass at WordPress 4.3 About page.

Still missing images and some string revisions.

See #32929.

#5 @obenland
5 years ago

In 33467:

About: Remove translation functions until strings are final.

See #32929.

#6 @obenland
5 years ago

  • Version set to trunk

@ryelle
5 years ago

#7 @ryelle
5 years ago

32929.2.diff adds the visuals & cleans up some related CSS. The images & video still need to be moved over to the w.org CDN, but they can be downloaded from the URLs in the patch.

#8 @obenland
5 years ago

In 33498:

About: Second pass at 4.3 about page.

Adds images and videos for major and minor features.
Restores a mangled placeholder in Formatting Shortcuts description.

Assets still need to be moved to the .org CDN once deemed final.

Props ryelle, melchoyce, helen.
See #32929.

#9 @obenland
5 years ago

The only two things left over here are a string review from @nacin (note adamsilverstein's suggestions) and png images from @ryelle/@melchoyce. It would be nice to have that finished in RC2.

#10 @melchoyce
5 years ago

Uploaded the screenshots as pngs (pre-compressed using imageoptim). Checked with @helen and it sounds like the icons are fine as SVGs. Let me know if there's anything I'm missing. :)

@obenland
5 years ago

#11 @obenland
5 years ago

Patch adds dotorg CDN links.

This ticket was mentioned in Slack in #core by obenland. View the logs.


5 years ago

@melchoyce
5 years ago

@melchoyce
5 years ago

#13 @melchoyce
5 years ago

If you have Jetpack installed, the class .jetpack-video-wrapper is applied, which adds extra margin to the bottom of the video, which makes the box size uneven. 32929.5.diff should overwrite that margin — but I'm having some sandbox issues, so it'd be great if someone could confirm.

#14 @georgestephanis
5 years ago

This sounds like something that is ideally better fixed in Jetpack, not in Core to accommodate Jetpack.

@melchoyce
5 years ago

#15 @melchoyce
5 years ago

32929.6.diff fixes a missing .

#16 @valendesigns
5 years ago

I have Jetpack active but don't see that class being added. Do I need to activate a certain module? I agree we should fix it upstream, but I doubt there's time.

#17 follow-up: @georgestephanis
5 years ago

Last edited 5 years ago by georgestephanis (previous) (diff)

#18 @valendesigns
5 years ago

Thanks @georgestephanis and @melchoyce yes the patch does fix it.

#19 in reply to: ↑ 17 @obenland
5 years ago

Replying to georgestephanis:

I think it's based on theme support.

Is there a reason to not restrict it to the front-end?

@ocean90
5 years ago

WP_List_Table

This ticket was mentioned in Slack in #core by obenland. View the logs.


5 years ago

#21 follow-up: @obenland
5 years ago

For the tagline, how about

Thank you for updating! WordPress 4.3 brings you a smoother writing and customization experience.

#22 in reply to: ↑ 21 @mrahmadawais
5 years ago

Replying to obenland:

For the tagline, how about

Thank you for updating! WordPress 4.3 brings you a smoother writing and customization experience.

Or maybe

Thank you for updating! WordPress 4.3 brings you a smoother writing, more customizable and refined responsive admin experience.

This ticket was mentioned in Slack in #core by obenland. View the logs.


5 years ago

#24 @morganestes
5 years ago

Based on the discussion in Slack today, I like "...easier and faster to create your site." for the opening line and "4.3 makes it even easier to format your content and customize your site" for the tag line. They're similar without being redundant, and puts the focus on content while still emphasizing site building.

#25 @markjaquith
5 years ago

  • "4.3 makes it even easier to format your content and customize your site"
  • Create your menu, update and assign it, all while live-previewing in the customizer. With every release, it becomes easier and faster to customize your site. The streamlined customizer design provides a mobile-first, accessibility-ready interface.

@obenland
5 years ago

#26 @obenland
5 years ago

32929.8.diff combines the second part of 32929.diff, 32929.3.diff, 32929.7.diff, and Marks suggestion in 25.

It also adds video handling so that only the ID has to be replaced once the new video is uploaded, and makes all strings translatable.

#27 follow-up: @helen
5 years ago

The customizer bit is a little heavy on the usage of "customize", the first part is still clunky, and it's not "mobile-first" (whatever that even means). Perhaps:

Create your menu, update it, and assign it, all while live-previewing in the customizer. With every release, it becomes easier and faster to make your site just the way you want it. The streamlined customizer design provides a mobile-friendly, accessibility-ready interface.

Why is it "accessibility-ready" and not "accessible"?

#28 @valendesigns
5 years ago

I think it's to give context to the term. However, for end users the context is lost on them, unless they're aware of accessibility in the first place.

#29 in reply to: ↑ 27 @obenland
5 years ago

Replying to helen:

How about:

Create your menu, update it, and assign it, all while live-previewing in the customizer. With every release, it becomes easier and faster to make your site just the way you want it. The streamlined customizer design provides a mobile-friendly and accessible interface.

#30 @obenland
5 years ago

  • Keywords has-patch added

Updated patch with revised Menu Customizer text.

@obenland
5 years ago

#31 @helen
5 years ago

32929.9.diff is looking good to me. I have one nitpick - the faux-bold of WP_List_Table that you get in some browsers looks like garbage, so we should specify a normal font-weight. I also wonder if it's worth a specific rule for that danged video margin that comes from Jetpack, given how widely it's installed.

#32 @ocean90
5 years ago

32929.9.diff looks good here too. It's also nice to see that subtitle support has been implemented into VideoPress. And the list is scrollable. \o/

@obenland
5 years ago

#33 @obenland
5 years ago

32929.10.diff merges 32929.9.diff with 32929.6.diff and addresses the font-weight issue.

#34 @obenland
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33613:

About: Third pass at 4.3 about page:

  • Improves some of the feature descriptions.
  • Uses .org CDN for images and feature video.
  • Fixes an overzealous Jetpack style that adds unwanted padding.
  • Uses more specific WP_List_Table header.
  • Adds 4.3 tagline to freedoms and credit page.
  • Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
  • Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.

@obenland
5 years ago

#35 @obenland
5 years ago

In 33631:

About: Update release video to use the correct ID.

Also adjusts locale handling to work with Videopress' subtitle implementation.

Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.

#36 @obenland
5 years ago

In 33632:

About: Use actual locale and not subtitle debug cruft.

H/t dimadin.

See #32929.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.