Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#32934 closed defect (bug) (fixed)

Network Admin: Avoid notice when visiting `network/site-*` URLs for a previously deleted site

Reported by: jeremyfelt's profile jeremyfelt Owned by: jeremyfelt's profile jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.1
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:


Each of the 4 edit site pages (info, users, themes, settings) will throw a notice if the requested site does not exist because $details is not populated to provide $details->site_id when checking user capabilities.

Attachments (1)

32934.diff (2.0 KB) - added by jeremyfelt 8 years ago.

Download all attachments as: .zip

Change History (6)

8 years ago

#1 @jeremyfelt
8 years ago

The attached 32934.diff checks for a positive get_blog_details() return and errors with "This site does not exist." if not valid.

Does that error message make sense?

#2 @jeremyfelt
8 years ago

Introduced in its original form as [15385] via #14185.

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.

8 years ago

#4 @jeremyfelt
8 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 33144:

Avoid PHP notice when attempting to edit a site that does not exist.

Show a more explicit error - "The requested site does not exist."

Fixes #32934.

#5 @jeremyfelt
8 years ago

In 33145:

Fix missing period in missing site error.

Props @ocean90.
See #32934.

Note: See TracTickets for help on using tickets.