#32945 closed defect (bug) (fixed)
Don't show Customizer link in network toolbars
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | high |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
r33130 adds a Customizer link to all toolbars. In multisite, this is also added to all Network screens too. I'm not sure this is the desired result.
Sorry for any issues with the patch as this is my first attempt. :-)
Attachments (2)
Change History (12)
#2
@
10 years ago
- Milestone changed from Awaiting Review to 4.3
- Priority changed from normal to high
#4
@
10 years ago
Thanks @helen. For some reason I was staring at Query Monitor's reporting is_network_admin()
and is_main_network()
ands seeing the same thing.
I will update patch.
#5
@
10 years ago
- Keywords has-patch added; needs-patch removed
Going to turn it off for the admin completely per UI chat, so the commit is going to look a little different :)
#6
@
10 years ago
- Owner set to helen
- Resolution set to fixed
- Status changed from new to closed
In 33147:
#7
follow-up:
↓ 8
@
10 years ago
Aww, I was looking forward to finally having Customize available in the toolbar for site admin views, especially on phones.
#8
in reply to:
↑ 7
@
10 years ago
Replying to ryan:
Aww, I was looking forward to finally having Customize available in the toolbar for site admin views, especially on phones.
I lost track of what "it" was in the chat about this.
https://wordpress.slack.com/archives/design/p1436465948001446
"It" is the customize icon in the toolbar for admin views. Seems the decision was to omit Customize from all admin views while we figure out the future in #32678. Okay, cool. My interpretation of the mockups and discussion on #32678 is that we'll likely have Customize back in the site admin toolbar once we decide to remove customize links from the admin menu, eliminating all Appearance vs. Customize context mixing. Network admin would continue omitting Customize from the toolbar, of course.
#10
@
10 years ago
We'll need at least one release (realistically more than that) with Customize always available in the admin bar before we can remove it from the admin menu under Appearance. So that would be a good reason to keep it there now in addition to adding it on the front-end, or we could hold off for now and just push back that potential future change further. It seems pretty likely that we'll have the persistent customize link in the admin bar, so I'm leaning more towards keeping it in the (non-network) admin (well, now adding it back).
@afragen There's a function for that :)
is_network_admin()
. Would also need to update the comment above it.