"View post" link should not change when sample permalink changes

[johnbillion]

This is a follow-up to #16477 which was fixed in 3.9 but has re-appeared.

To reproduce:

• Go to edit a post
• Change the permalink
• Click on "View post" and you get a 404 because the href has been changed to the new sample permalink but the post hasn't been updated yet

The "View post" link should always point to the permalink of the currently saved post.

r27508 was the initial fix. Need to find out where the regression occurred.

[johnbillion]

Broken in r32002

[boonebgorges]

The reasoning behind [32002] was to make View Post point to a pretty permalink for scheduled posts; get_permalink() only returns a pretty permalink for posts with post_status=publish. The error in that changeset was to trust the $post_name variable, which is the *updated* post slug, rather than the one stored in the database. As you suggest, the saved slug should always be used.

See 32954.diff​, where I suggest using $post->post_name rather than $post_name in the str_replace() that generates the pretty permalink. I put in a special case if ( 'publish' === $post->post_status ) { $pretty_permalink = get_permalink( $post ); }; I'm pretty sure this is equivalent to the str_replace() in the else clause, but perhaps it makes it a bit clearer what's going on.

@johnbillion Does this seem right to you?

[johnbillion]

In 33773:

Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.

Fixes #32954
Props boonebgorges, johnbillion