WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#32961 closed defect (bug) (fixed)

MS Sites List Table: Duplicate span elements are output for row actions

Reported by: jeremyfelt Owned by: jeremyfelt
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.1
Component: Networks and Sites Keywords: has-patch ui-feedback
Focuses: administration, multisite Cc:

Description

When row_actions() was introduced in [15571], many (most?) of the existing span elements were removed from the arrays of actions built for list tables. The MS Sites List Table survived the change and has resulted in duplicate output ever since. <span class="edit"><span class="edit"><a href="">Edit</a></span> | </span>.

Attachments (3)

32961.diff (6.1 KB) - added by jeremyfelt 6 years ago.
before-32961.diff.png (29.0 KB) - added by jeremyfelt 6 years ago.
after-32962.diff.png (28.5 KB) - added by jeremyfelt 6 years ago.

Download all attachments as: .zip

Change History (8)

@jeremyfelt
6 years ago

#1 follow-up: @jeremyfelt
6 years ago

  • Keywords ui-feedback added

One issue here is that the class names would change for sites that had been flagged. Previously, the spam action link and the unspam action link were both wrapped with a <span class="spam".... The unspam link would end up being <span class="spam"><span class="unspam"><a href="">Unspam</a></span></span> and the red color attached to .spam a would be applied. The same change happens with activate/unactivate, archive/unarchive.

We can add a rule to apply the same style to unspam or allow the color to change to blue. The attached screenshots show the visual change when a site is marked as spam.

#2 @jeremyfelt
6 years ago

  • Milestone changed from 4.3 to Future Release

Not going to clutter the 4.3 list with this. :) It'd be nice to pick this up alongside #15801.

#3 @jeremyfelt
6 years ago

  • Milestone changed from Future Release to 4.4

#4 in reply to: ↑ 1 @SergeyBiryukov
6 years ago

Replying to jeremyfelt:

We can add a rule to apply the same style to unspam or allow the color to change to blue.

I think the latter is fine, unspamming is not a destructive action.

#5 @jeremyfelt
6 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 33848:

Multisite: Remove duplicate span element output from row actions

Fixes #32961.

Note: See TracTickets for help on using tickets.