Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32963 closed defect (bug) (fixed)

Network Admin: Actions and messaging on row actions in MS Sites List table should be handled better

Reported by: jeremyfelt's profile jeremyfelt Owned by: jeremyfelt's profile jeremyfelt
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:


There are a few changes we can make to the row actions attached to sites in the MS Sites List Table that can make for a cleaner process.

Attachments (1)

32963.diff (9.0 KB) - added by jeremyfelt 9 years ago.

Download all attachments as: .zip

Change History (4)

9 years ago

#1 @jeremyfelt
9 years ago

32963.diff does a few things:

  • Simplify the URLs used for row actions to remove messaging and site name (domain).
  • Add messaging to the managed list of actions that handles the request to use for the confirmation page.
  • Lookup the site address from the passed site ID rather than using the domain passed in the URL.

#2 @jeremyfelt
9 years ago

  • Owner set to jeremyfelt
  • Resolution set to fixed
  • Status changed from new to closed

In 33173:

Add better handling for actions and messaging in MS Sites List Table row actions

  • Simplify URLs used for row actions to remove messaging and site domain/path.
  • Use confirmation messaging from a managed list of actions when handling the request.
  • Find the site address from the site ID rather than using information passed in the URL.

Fixes #32963.

#3 @jeremyfelt
9 years ago

In 33194:

Handle MS Sites bulk action verification separately from individual actions.

After [33173], bulk actions would not process due to broken verification of the bulk-sites action. This reintroduces the proper action and treats bulk actions differently than individual site actions.

See #32963.

Note: See TracTickets for help on using tickets.