WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#32964 closed defect (bug) (fixed)

Site Icon: Add 192x192 site for Android devices

Reported by: kraftbj Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Android uses 192x192 for home screen tiles and for favicons used when using the application switcher to change Chrome tabs.

Currently, if a 192x192 size is not provided, it falls back to Apple icon meta; however, this is deprecated and noted to be removed in a future version (https://developer.chrome.com/multidevice/android/installtohomescreen#icon)

See #16434 (master ticket)

Attachments (2)

32964.patch (1.4 KB) - added by kraftbj 2 years ago.
Adds 192 in the size array and outputs it.
32964.2.patch (2.7 KB) - added by kraftbj 2 years ago.
32964.patch plus unit tests.

Download all attachments as: .zip

Change History (8)

@kraftbj
2 years ago

Adds 192 in the size array and outputs it.

#1 @kraftbj
2 years ago

  • Keywords has-patch added

#2 @jorbin
2 years ago

  • Keywords needs-refresh needs-unit-tests added
  • Milestone changed from Awaiting Review to 4.3

Patch needs to be updated to take into account the unit tests that we now have for site_icon

@kraftbj
2 years ago

32964.patch plus unit tests.

#3 @kraftbj
2 years ago

  • Keywords needs-refresh needs-unit-tests removed

32964.2.patch amends the unit tests to account for a new default size. Ran phpunit on a fresh copy of trunk, then with 32964.patch, then again with .2 to confirm that the original patch invalidated the tests and the .2 resolved.

#4 @obenland
2 years ago

12px. ಠ_ಠ

#5 @kraftbj
2 years ago

If we can get all cell phone makers to use the same power connection (Apple being the hold out on this go round), then we can ask them to please just agree on something together :)

#6 @obenland
2 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 33202:

Site Icon: Add Android-specific app icon.

Falling back to Apple app icons is deprecated behavior and will not work
forever. 192px is the recommended size for that icon.

Props kraftbj.
Fixes #32964.

Note: See TracTickets for help on using tickets.