Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#32968 closed defect (bug) (fixed)

Plugins list table: description header and cells announced as "clickable"

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: has-patch
Focuses: accessibility, javascript Cc:

Description

Small thing but it's a bit confusing for screen reader users. Seems it happens just with Firefox + NVDA. When navigating through the Plugins table, the description header and all the description cells get announced as "clickable" elements. See in the screenshot below, where the "NVDA Speech Viewer" reports the text being announced.

https://cldup.com/WwlCmvkwel.png

As far as I see, there's a delegated click event needed to open the thickbox Plugin details popup that causes this. Simply delegating on the plugin-description div instead of the table cells fixes this, as the div doesn't get announced by screen readers.

Attachments (2)

32968.patch (548 bytes) - added by afercia 9 years ago.
32968.2.patch (556 bytes) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (9)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • avoid the Plugins table Description cells being announced as "clickable" elements to screen readers

#2 @afercia
9 years ago

  • Owner set to afercia
  • Status changed from new to assigned

#3 @SergeyBiryukov
9 years ago

The Details link is not in the .plugin-description div, looks like it should be .plugin-version-author-uri.

#4 @afercia
9 years ago

Ops, you're right. Also, the plugin-description selector missed the leading dot ".". Looks like it worked just because of the default event that thickbox delegates on the body.

https://cldup.com/cRA7WhAO7L.png

The new patch uses .plugin-version-author-uri btw noticed this way, also in the plugin cards, there are two click events: the one from plugin-install.js and the one from thickbox.js and both will fire when clicking on the details link. Open to suggestions :)

@afercia
9 years ago

#5 @afercia
9 years ago

there are two click events

Nevermind, it's using call().

#6 @SergeyBiryukov
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33462:

Plugins list table: Make selector for Details links more specific to prevent the Description header from being announced as "clickable".

props afercia.
fixes #32968.

#7 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 4.3
Note: See TracTickets for help on using tickets.