WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#32970 closed defect (bug) (fixed)

Site Icon (settings): accessibility improvements

Reported by: afercia's profile afercia Owned by: obenland's profile obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords:
Focuses: accessibility Cc:

Description

The new Site Icon feature in the General Settings screen can be improved a bit for accessibility especially about labels, descriptions, and images alt attributes.

Attachments (1)

32970.patch​ (5.2 KB) - added by afercia 10 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
10 years ago

#1 @afercia
10 years ago

In the proposed patch:

  • proper headings hierarchy (should we review the new "Preview" H2 styling? See screenshot below)
  • improve images alt attributes (open to suggestions for better strings) and add missing one
  • remove redundant orphaned label
  • remove button labels: though buttons can have labels, we can just use aria-label and aria-describedby

https://cldup.com/rerQ9OxMOT.png

#2 @jorbin
10 years ago

  • Milestone changed from Awaiting Review to 4.3

#3 @afercia
10 years ago

For reference, the "Preview" heading before the patch is an h3 and looks smaller of course:

https://cldup.com/8E3hmucAtH.png

Since this is a new screen, maybe we could fix the styling now. Open to wait for 4.4 where we should start scaling down the overall headings hierarchy in the admin as consequence of #31650.

#4 @obenland
10 years ago

  • Owner set to obenland
  • Status changed from new to accepted

Patch looks good. What is the id site-icon-desc for?

#5 @obenland
10 years ago

Never mind, the aria-describedby.

#6 @obenland
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33180:

Site Icon: Improve a11y in Settings.

Props afercia.
Fixes #32970.

Note: See TracTickets for help on using tickets.