WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#32988 closed enhancement (fixed)

Improve unit tests for update_blog_details()

Reported by: jeremyfelt Owned by:
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords:
Focuses: multisite Cc:

Description

Our tests for update_blog_details() are pretty comprehensive, but could be organized better as their own file and could take advantage of a data provider in at least one place.

Using this ticket to track some changes.

Change History (4)

#1 @jeremyfelt
5 years ago

In 33253:

Tests: Move update_blog_details() tests to their own file.

Reduce some of the clutter in tests/multisite/site.php and introduce tests/multisite/updateBlogDetails.php. Tests moved over are verbatum at this point.

See #32988.

#2 @jeremyfelt
5 years ago

In 33254:

Tests: Use a data provider when testing path slashing in update_blog_details().

Trims down 11 tests to 1 clean area of testing and makes for a much saner read.

See #32988.

#3 @jeremyfelt
5 years ago

In 33255:

Tests: Use a data provider when testing site flags in update_blog_details().

See #32988.

#4 @jeremyfelt
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.