WP_Text_Diff_Renderer_Table class's '_changed()' is having bug

[vishalkakadiya]

WP_Text_Diff_Renderer_Table class on line 319

When anyone changed the content at that time the return data is containing one extra '<td>&nbsp;</td>', that is not required see in the "_changed()" function.

Changed the line no 319

"$r .= '<tr>' . $this->deletedLine( $orig_line ) . $this->emptyLine() . $this->addedLine( $final_line ) . "</tr>\n";"

[utkarshpatel]

Patch #33004

[dipesh.kakadiya]

Need to change '_changed' & '_context' function

[adamsilverstein]

@vishalkakadiya: Thanks for the bug report!

I'm not sure that blank line call is a bug, although clearly in your case it is producing unintended results.

If you examine the constructed html for the 'split' diff view, you should see a series of rows consisting of three columns, a left hand 'removed' column, a middle spacer column, and a right hand added column. (see ​http://cl.ly/image/0V2m2i3I0O0N). Any html inside the diffs should be encoded and not break the layout.

Removing the middle column is likely to have unintended consequences elsewhere as the entire page structure assumes three columns. Before I close this ticket as 'won't fix, I'd like to dig a bit more to see how you are getting into the situation your screenshot illustrates. Can you help by adding some additional detail?

• Are you testing on wp 4.2 or trunk?
• Anything special to reproduce this issue, do you see it only on that one post/revision, or something you see elsewhere as well?
• Can you try reproducing with all plugins disabled and using the default theme?
• If the issue persists, can you provide a db dump of your posts table or just the part referencing this post and its revisions?

Thanks.

[vishalkakadiya]

@adamsilverstein

I think one of the plugin is conflict with code. This issue was came on all the posts, but it is resolved now.

Thanks for the help.