WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#33005 closed defect (bug) (fixed)

Removing header image attachement does not remove header_image_data theme mod

Reported by: CreativeInfusion Owned by: obenland
Priority: normal Milestone: 4.3
Component: Themes Version: 3.0
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

If you delete an attachment from the media library that is set as a header image then although it deletes the header_image theme mod it does not delete the header_image_data theme mod.

This results in incompatible data being returned from get_custom_header and get_header_image.

Related #20871 #25156

Attachments (1)

33005.diff​ (620 bytes ) - added by CreativeInfusion 11 years ago.

Download all attachments as: .zip

Change History (3)

@CreativeInfusion
11 years ago

#1 @obenland
11 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → 4.3
  • Owner set to obenland
  • Status new → accepted
  • Version 4.0 → 3.0

Nice find CreativeInfusion.

Introduced in [14850].

#2 @obenland
11 years ago

  • Resolution → fixed
  • Status accepted → closed

In 33278:

Properly clean up header image data when the attachment is deleted.

Props CreativeInfusion.
Fixes #33005.

Note: See TracTickets for help on using tickets.