Opened 10 years ago
Closed 10 years ago
#33022 closed defect (bug) (fixed)
TinyMCE: the more tag placeholder is not displayed properly
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Attachments (5)
Change History (17)
#2
in reply to:
↑ 1
@
10 years ago
Replying to azaozz:
Pinging @jacklenox: not sure why
width: auto;
has to be forced on all images and why this has to be!important
.
I seem to recall that this depends on the settings of the image itself.
While removing !important
will be ok for this more tag example, any large image which has been inserted via the media editor and has had an explicit width defined will break the editing experience for small screen users (where the screen is smaller than the image of course!).
Removing the !important bit fixes it (yeah, really hate the !important in css) :) Another possible fix is to add min-width to the image placeholders in the default editor css.
I'm not sure what this will fix, the problem is that some images are too large for the editor on small screens.
I didn't realise this had broken the more tag though so I'm sorry about this!
Maybe we need to create some sort of exception based on the class of the more tag placeholder image?
#3
@
10 years ago
- Keywords has-patch added
- Owner set to azaozz
- Status changed from new to assigned
Would that fix it?
This ticket was mentioned in Slack in #core by obenland. View the logs.
10 years ago
#6
@
10 years ago
Lets add min-width in the default editor style for now. We're planning to add something similar by default, will revisit it then.
#8
follow-up:
↓ 9
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
The important
seems to be unnecessary in [31849].
#9
in reply to:
↑ 8
@
10 years ago
The
important
seems to be unnecessary...
It also breaks captions text wrapping and ability to align them in the center.
Pinging @jacklenox: not sure why
width: auto;
has to be forced on all images and why this has to be!important
.Removing the !important bit fixes it (yeah, really hate the !important in css) :) Another possible fix is to add min-width to the image placeholders in the default editor css.
Another thing to keep in mind is that the editor runs in an iframe, and the
@media screen and (max-width: 660px)
applies to the iframe width, not the parent window width. So that media rule triggers most of the time, up to 1260px parent window width.