Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33032 closed defect (bug) (fixed)

User password strength result provides no feedback for screen readers

Reported by: rianrietveld's profile rianrietveld Owned by: rianrietveld's profile rianrietveld
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch dev-feedback
Focuses: accessibility Cc:

Description

When entering or changing the user password, the strength of the password is displayed below the input field in a div id=pass-strength-result. There is no feedback for screen reader users about the value or change of this password strength.

Attached patch that adds

  • aria-live="polite" to #pass-strength-result, so that the changes are read out
  • aria-labelledby="pass-strength-result" to the input field with the password, so the initial state of #pass-strength-result is read out

Patch tested with VoiceOver

Attachments (4)

33032.patch (4.7 KB) - added by rianrietveld 9 years ago.
Adds ARIA for screen reader feedeback
33032-2.patch (6.4 KB) - added by rianrietveld 9 years ago.
Adds the word password to the strength indicator and the hide/show button
33032.diff (6.3 KB) - added by obenland 9 years ago.
33032.2.diff (6.7 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (13)

@rianrietveld
9 years ago

Adds ARIA for screen reader feedeback

#1 @rianrietveld
9 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to rianrietveld
  • Status changed from new to assigned

#2 @obenland
9 years ago

  • Milestone changed from Future Release to 4.3

What kind of dev feedback are you looking for?

@rianrietveld
9 years ago

Adds the word password to the strength indicator and the hide/show button

#3 @rianrietveld
9 years ago

Second patch adds the word Password to the strength indicator and the hide/show button, as discusses with @afercia.

Version 0, edited 9 years ago by rianrietveld (next)

This ticket was mentioned in Slack in #core by obenland. View the logs.


9 years ago

#5 @obenland
9 years ago

Is the password context through the row heading not obvious enough?

#6 @rianrietveld
9 years ago

In the case of the show/hide button it's not obvious.
A screenreader user can call a list of buttons, and the only response they get is "hide".

For the password strength: it just gets read out every time you stop typing and the status of the strength has changed.
Then it's not really related to a row heading.
But I agree that from the context you can understand that this is related to the password.
But think for overall usability it may be better to add password the text, not only for screenreader users.

Patch 1 is necessary, patch 2 makes it more usable and pretty.

@obenland
9 years ago

@afercia
9 years ago

#7 @afercia
9 years ago

Refreshed a bi the latest patch to change just to small things as agreed with @obenland. We can always iterate and try further improvements later.

  • use aria-describedby for the input field initial "strength" state instead of aria-labelledby so it will be read out after the field and maybe is more appropriate as "description"
  • Show/Hide button aria-label should be set on the button itself not on the inner span

#8 @afercia
9 years ago

Side note: I'd also recommend to add the word "password" to the strength indicator messages :)

#9 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33353:

Passwords: Add password strength meter feedback for screen readers.

Also gives context to the show/hide button.

Props rianrietveld, afercia.
Fixes #33032.

Note: See TracTickets for help on using tickets.