Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#33036 closed defect (bug) (fixed)

Ampersand in theme name not rendering for active theme.

Reported by: icaleb's profile iCaleb Owned by: dd32's profile dd32
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Themes Keywords:
Focuses: ui, administration, template Cc:

Description

When there is an html entity in the theme name, it does not render when the theme is active. Screenshots below:

Un-active Theme Name: http://cld.wthms.co/1bRrk/2RZYSlgb & http://cld.wthms.co/17E6d/56JSuMv1

Active Theme: http://cld.wthms.co/12EOf/1NWM1c3x

Attachments (1)

33036.patch (1.3 KB) - added by iCaleb 9 years ago.
Fixes html entity escaping

Download all attachments as: .zip

Change History (5)

#1 @iCaleb
9 years ago

Also a problem in the customizer: http://cld.wthms.co/1bb94/1a6jGhiM

@iCaleb
9 years ago

Fixes html entity escaping

#2 @dd32
9 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Version changed from trunk to 4.2

The themes.php change was added in r31905 which reverted r26638.

#3 @dd32
9 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 33327:

Allow HTML/entities in the Active Theme Name in the themes.php & Customizer templates.

Props iCaleb
Fixes #33036

#4 @dd32
9 years ago

For the record here, Theme headers can contain limited HTML & HTML entities. WP_Theme sanitizes the headers as appropriate.

Note: See TracTickets for help on using tickets.