WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33038 closed defect (bug) (fixed)

Site Icon preview labels for browser and app icon need vertical spacing

Reported by: eliorivero Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch needs-refresh
Focuses: ui Cc:
PR Number:

Description

The labels As a browser icon and As an app icon are vertically too close to the preview below them. This is more noticeable in app icon where the "p" descendants are almost touching the image. The patch adds a 5px vertical margin to avoid this.

https://photos-2.dropbox.com/t/2/AADfR9j0xivvfmXryAQUrYJb4rAxz7NAwvK4Nxlynwqa9w/12/15152746/png/32x32/1/_/1/2/margin-top.png/EKD4owsY-6ECIAEoAQ/E3U9zise52ib22PuCKZvzlGurgbnaR7VkzNCY4PVKh4

Attachments (4)

33038.patch (470 bytes) - added by eliorivero 4 years ago.
Adds vertical spacing between browser and app icon previews and their labels
33038.png (66.0 KB) - added by eliorivero 4 years ago.
Show what the patch does, adding vertical spacing between labels and previews
33038-2.patch (545 bytes) - added by eliorivero 4 years ago.
Patch refreshed after [33329]
33038-2.png (158.9 KB) - added by eliorivero 4 years ago.
Preview of what the patch does, refreshed after [33329]

Download all attachments as: .zip

Change History (12)

@eliorivero
4 years ago

Adds vertical spacing between browser and app icon previews and their labels

#1 @swissspidy
4 years ago

  • Focuses administration removed

Image is not visible for me. Can you add before and after screenshots without Dropbox so we can see what this patch does?

@eliorivero
4 years ago

Show what the patch does, adding vertical spacing between labels and previews

#2 @eliorivero
4 years ago

Added and image showing before (left) and after (right) the patch.

#3 @dd32
4 years ago

  • Milestone changed from Awaiting Review to 4.3

Shifting to 4.3 for review purposes.

#4 @obenland
4 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#5 @obenland
4 years ago

I'll get that in after #16434.

#6 @obenland
4 years ago

  • Keywords has-patch needs-refresh added

Patch needs a refresh after [33329].

#7 @obenland
4 years ago

  • Component changed from Administration to Customize

@eliorivero
4 years ago

Patch refreshed after [33329]

@eliorivero
4 years ago

Preview of what the patch does, refreshed after [33329]

#8 @obenland
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33332:

Site Icon: Improve vertical spacing in preview.

Props eliorivero.
Fixes #33038.

Note: See TracTickets for help on using tickets.