WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#33046 closed defect (bug) (fixed)

Export screen: missing labels and accessibility improvements

Reported by: afercia Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

In the Export screen, form fields do have labels but they're not correctly associated. We could also further improve semantics and accessibility grouping together form controls that are logically grouped, using fieldsets and legends.

Would like to discuss a bit with the accessibility team what should we do with form elements that are revealed inside the expandable panels: as soon as users select the Posts or Pages radio buttons, additional form controls get displayed but screen reader users don't get notified they've just got additional options. See screenshot below:

https://cldup.com/8LgP0MaN6e.png

Attachments (2)

33046.patch (6.1 KB) - added by afercia 3 years ago.
33046.2.patch (7.7 KB) - added by afercia 2 years ago.

Download all attachments as: .zip

Change History (8)

@afercia
3 years ago

#1 @afercia
3 years ago

First pass:

  • associate form labels with their controls
  • use fieldset and legend elements to group related form controls
  • use aria-describedby for the first radio button description
  • improve a bit the layout on small screens

See screenshot (with the two panels expanded for demoing purposes):

https://cldup.com/ee9wyloZel.png

#2 @afercia
3 years ago

  • Focuses ui added

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


2 years ago

@afercia
2 years ago

#5 @afercia
2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.4
  • Owner set to wonderboymusic
  • Status changed from new to assigned

Refreshed patch after the recent changes in [34326]. Fixes also the newly added labels association. Assigning to @wonderboymusic for his kind review and feedback.

#6 @wonderboymusic
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35316:

Export: add missing labels and improvement accessibility of the Export screen.

Props afercia.
Fixes #33046.

Note: See TracTickets for help on using tickets.