WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#33047 closed defect (bug) (fixed)

Table headers shouldn't be empty or shouldn't be table headers

Reported by: afercia Owned by: afercia
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords:
Focuses: accessibility Cc:

Description

Spotted a couple of places where some th are empty. The th element conveys a semantic meaning and it's used by assistive technologies to establish a relationship with the related table cells. This implies a table header shouldn't be empty. Most of all, when used just for layout purposes, shouldn't be a th in the first place and a td should be used instead.

https://cldup.com/5zLNN7YDR9.png

Attachments (2)

33047.patch (1.7 KB) - added by afercia 5 years ago.
33047.2.patch (392 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
5 years ago

#1 @afercia
5 years ago

As I see it, there are two possible ways to solve this:

  • add some text in the empty table headers: for example, why the th related to the 'Log Out of All Other Sessions' button is empty?
  • keep it simple and just use a td

The proposed patch takes the second approach. Open to hear any thoughts and feedback.

#2 @afercia
5 years ago

  • Owner set to afercia
  • Status changed from new to assigned

@afercia
5 years ago

#3 @afercia
5 years ago

Refreshed patch now that the user session table header has some proper text, see see 33368. See screenshot:

https://cldup.com/yK1VnWzqQs.png

#4 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33456:

Replace empty table header with a table cell.

props afercia.
fixes #33047.

#5 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.3
Note: See TracTickets for help on using tickets.