Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#33062 closed defect (bug) (fixed)

Comment status box focus management and accessibility

Reported by: afercia's profile afercia Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Comments Keywords: has-patch
Focuses: accessibility, javascript Cc:

Description

When editing a comment, the Comment status box has the same functionality to edit the timestamp date as the Post Publish box. Focus should be handled in the same way, see #33060.

See the screenshot below:

  • when clicking the Edit link, focus should be moved to the first form element when the animation is complete
  • when clicking OK or Cancel, focus should be moved back to the Edit link before the animation starts

https://cldup.com/IZiFpmVCLm.png

Currently, when clicking Edit, OK or Cancel, focus is lost and users have to start tabbing again from the document root.

Worth noting for accessibility the orange used for the Pending radio button label doesn't have a sufficient color contrast ratio but this is out of the scope of this ticket.

Attachments (2)

33062.patch (2.7 KB) - added by afercia 10 years ago.
33062.2.patch (2.3 KB) - added by afercia 10 years ago.

Download all attachments as: .zip

Change History (6)

@afercia
10 years ago

#1 @afercia
10 years ago

  • Keywords has-patch added

Proposed patch adds focus management for the edit timestamp links and tries to clean up a bit. See similar patches proposed for the Post Publish box, #33059 and #33060.

@afercia
10 years ago

#2 @afercia
10 years ago

Refreshed patch after 33348, 33349 and 33352.
Move focus back to 'edit' when saving changes and tries to clean up a bit.

#3 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.3

#4 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33422:

Comment status box: Move focus back to Edit link when changing the date.

props afercia.
fixes #33062.

Note: See TracTickets for help on using tickets.