WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33065, comment 3


Ignore:
Timestamp:
07/26/2015 01:13:11 AM (6 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33065, comment 3

    initial v1  
    33* `array_map()` doesn't operate on an array in place - you need to grab the return value. Ie `$post_name__in = array_map( 'sanitize_title_for_query', $q['post_name__in'] )`
    44* In the documentation, it looks like you're chopping up the `$posts_per_archive_page` lines :)
    5 * I'd suggest moving the new block so that it's near the existing parsing for 'name' and 'pagename', perhaps even making it into an `elseif` condition alongside the name/pagename checks. This would make it clearer how the 'post_name__in' interacts with the existing parameters (which would be especially important if we introduced 'post_name__not_in').
     5* I'd suggest moving the new block so that it's near the existing parsing for 'name' and 'pagename', perhaps even making it into an `elseif` condition alongside the name/pagename checks. This would make it clearer how the `'post_name__in'` interacts with the existing parameters (which would be especially important if we introduced `'post_name__not_in'`).