Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#33077 closed defect (bug) (fixed)

pw-weak vs. pw_weak, IDs vs. classes

Reported by:	johnjamesjacoby	Owned by:	markjaquith
Priority:	normal	Milestone:	4.3
Component:	Administration	Version:	4.3
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	ui, administration

Description

Breaking apart from #WP32589, there are a few places where the pw-weak clean-up in r33246 missed a few spots.

Related to this is the for label attribute, which isn't necessary when the label wraps the checkbox, and actually causes targeting issues (in Webkit for sure; possibly others.)

Patch imminent.

Attachments (2)

33037.01.patch (1.1 KB ) - added by johnjamesjacoby 11 years ago.
33077.02.patch (1.2 KB ) - added by johnjamesjacoby 11 years ago.

Download all attachments as: .zip

Change History (8)

@johnjamesjacoby
11 years ago

Attachment 33037.01.patch added

This ticket was mentioned in Slack in #core-passwords by jjj. View the logs.

11 years ago

@johnjamesjacoby
11 years ago

Attachment 33077.02.patch added

#2 @johnjamesjacoby
11 years ago

33077.02.patch is a portion of 32589.10.patch, surgically removed for easier scrutinizing.

#3 @markjaquith
11 years ago

Owner set to markjaquith
Resolution → fixed
Status new → closed

Fix up and normalize pw_weak/pw-weak IDs and labels.

props johnjamesjacoby
fixes #33077

#4 @johnjamesjacoby
11 years ago

Helen suggested in Slack to remove the pw-weak ID's on the checkboxes entirely.

I can confirm they are no longer referenced in our CSS or JS, so it's safe to remove them if we'd like.

#5 @obenland
11 years ago

+1

#6 @SergeyBiryukov
11 years ago

Remove unused pw-weak ID attributes.

Note: See TracTickets for help on using tickets.

Download in other formats: