Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#33080 closed enhancement (fixed)

User password field is under "About Yourself" heading

Reported by: johnjamesjacoby Owned by: markjaquith
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: administration Cc:

Description

Breaking apart from #WP32589, since probably forever, the "Password" fields in wp-admin/user-edit.php have been underneath the "Biographical Info" field, under the "About Yourself" heading.

In my opinion, the lack of separation is made more prominent by the introduction of "Log Out of All Sessions" button, and the new "Generate new Password" button. This is because these two buttons introduce a new user experience to a user's profile area: clicking a button to perform a task that doesn't involve saving their profile data.

I'd like to recommend a new heading be introduced to separate out these two buttons from "Biographical Info"

Patch imminent.

Attachments (2)

33080.01.patch (444 bytes) - added by johnjamesjacoby 7 years ago.
Screen Shot 2015-07-22 at 1.46.23 PM.png (219.8 KB) - added by johnjamesjacoby 7 years ago.

Download all attachments as: .zip

Change History (7)

#1 @johnjamesjacoby
7 years ago

33080.01.patch is a portion of 32589.10.patch, surgically removed for easier scrutinizing.

It suggests adding an "Account Management" heading below "Biographical Info" and above "New Password".

This ticket was mentioned in Slack in #core-passwords by jjj. View the logs.


7 years ago

#3 @johnjamesjacoby
7 years ago

Tangentially related: the "Additional Capabilities" heading and section at the bottom of user-edit.php is neither very pretty nor developer friendly, and should be made better later in another ticket.

#4 @johnjamesjacoby
7 years ago

For context & backstory, I can imagine this change being somewhat controversial for the following reasons:

  • It introduces the concept to the "user" of separating a "profile" from their "account"
  • I'm not sure if we have a language guide that outlines (or even mentions) the word "account" vs "profile"
  • I vaguely recall a conversation with jenmylo years ago where "Profile" won over "Account" for the top level menu item text, but IMO the vagueness of "New Password" being under "About Yourself" is unrelated to introducing a new heading to that, and separating the functionality out here is better than what we have currently.

For what it's worth, in BuddyPress, we are just now in the process of defining the terms: user, member, profile, & account. Technically, they're all different things pertaining to the same central object, and, again IMO, passwords and sessions pertain to the "account" where as a "profile" is how the user of the account describes themselves. Phew!

Last edited 7 years ago by johnjamesjacoby (previous) (diff)

#5 @markjaquith
7 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 33367:

Move password and session items into "Account Management" profile section.

fixes #33080
props johnjamesjacoby

Note: See TracTickets for help on using tickets.