Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33082 closed enhancement (fixed)

"New Password" and "Sessions" string changes in user-edit.php

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: markjaquith's profile markjaquith
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords:
Focuses: ui, administration Cc:

Description

Breaking apart from #WP32589, I have some suggestions that I believe improve upon the existing verbiage used for managing your password and sessions within your user profile.

Attachments (3)

33082.01.patch (3.1 KB) - added by johnjamesjacoby 9 years ago.
Screen Shot 2015-07-22 at 2.32.23 PM.png (223.7 KB) - added by johnjamesjacoby 9 years ago.
33082.02.patch (3.2 KB) - added by johnjamesjacoby 9 years ago.

Download all attachments as: .zip

Change History (11)

#1 @johnjamesjacoby
9 years ago

Old Strings, in order of presentation:

  • "Generate new password"
  • " "
  • "Log Out of All Other Sessions"
  • "Left your account logged in at a public computer? Lost your phone? This will log you out everywhere except your current browser."
  • "Log %s out of all sessions"

New Strings:

  • "Generate Password"
  • "Sessions"
  • "Log Out Everywhere"
  • "Did you lose your phone or leave your account logged in at a public computer? You can log out everywhere else, and stay logged in here."
  • "Log %s out of all locations"

Reasoning:

  • Because you cannot generate an old one
  • Because a non-breaking space is not very helpful
  • Because it's less wordy
  • Because questions should start obviously and be answered directly
  • Because 'locations' seems less like jargon to less fluent WordPress users

#2 follow-up: @jorbin
9 years ago

"Log Out Everywhere" isn't accurate since the current session isn't destroyed.

#3 in reply to: ↑ 2 @johnjamesjacoby
9 years ago

Replying to jorbin:

"Log Out Everywhere" isn't accurate since the current session isn't destroyed.

True, it's not 100% accurate. I find the string "Log Out of All Other Sessions" to be long, and the titlecase hurts my eyes because it's so long. Can you think of any shorter alternatives?

This ticket was mentioned in Slack in #core-passwords by jjj. View the logs.


9 years ago

#5 @johnjamesjacoby
9 years ago

33082.02.patch updates the following:

  • "Log Out Everywhere Else"
  • Uses "Sessions" in the <th> ("Locations" was also suggested)

#6 @markjaquith
9 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 33368:

Improve the "sessions" section strings.

fixes #33082
props johnjamesjacoby

#7 @ocean90
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Help text needs to be updated as well.

Last edited 9 years ago by ocean90 (previous) (diff)

#8 @SergeyBiryukov
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 33420:

Update help text after [33368].

fixes #33082.

Note: See TracTickets for help on using tickets.