WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33084 closed defect (bug) (fixed)

dashicons-hidden not aligned vertically with dashicons-visibility

Reported by: markjaquith Owned by: markjaquith
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: General Keywords:
Focuses: Cc:
PR Number:

Description

These two icons both share the eye, but they aren't aligned vertically with each other, so if you use it in a toggle (common use case), it will move up and down by what looks like a full pixel.

Attachments (4)

dashicons-toggle.mov (87.1 KB) - added by markjaquith 4 years ago.
33084.jpg (107.5 KB) - added by ocean90 4 years ago.
fonts.zip (107.2 KB) - added by liljimmi 4 years ago.
New font files with hidden icon fixed by @empireoflight
33084.patch (68.5 KB) - added by liljimmi 4 years ago.
CSS with hidden Dashicon fixed by @empireoflight

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in Slack in #design-dashicons by mark. View the logs.


4 years ago

@ocean90
4 years ago

@liljimmi
4 years ago

New font files with hidden icon fixed by @empireoflight

@liljimmi
4 years ago

CSS with hidden Dashicon fixed by @empireoflight

#2 @markjaquith
4 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 33373:

Fix vertical alignment of the eye in the "hidden" dashicon to match "visibility".

fixes #33084
props empireoflight, liljimmi

#3 @ocean90
4 years ago

In 33394:

Dashicons: Fix font ID in SVG file.

see #33084.

Note: See TracTickets for help on using tickets.