1Password thinks the text "log in" a form should trigger a password save

[markjaquith]

This is really weird, but if you have a plain, unlinked, un-evented paragraph like this in a form:

<p>There's a frog on the bump on the log in the bottom of the sea</p>

and you also have a password filled in somewhere in the form...

and you click the word "frog" in that sentence...

1Password will prompt you to save the password, because it thinks you're submitting the form. YEAH.

So... in our install screen:

You will need this password to log in, please store it in a secure location.

I'm suggesting we do:

You will need this password to log in, please store it in a secure location.

Which fools 1Password.

[markjaquith]

In 33387:

Prevent 1Password from thinking the text "log in" should trigger a password save prompt

fixes #33091

[boonebgorges]

This is the weirdest thing ever. Do we know whether 1Password is going to do the same thing in other languages? Should there be a translator note to that effect?

[DrewAPicture]

Replying to boonebgorges:

This is the weirdest thing ever. Do we know whether 1Password is going to do the same thing in other languages? Should there be a translator note to that effect?

Was just going to suggest at least a translator comment to indicate why the non-breaking space is in there. So +1 for a translator comment. @ocean90: Thoughts?

[markjaquith]

Translator's note could work. No idea what the trigger phrases are in other languages.

Also: ​https://twitter.com/1Password/status/624241718897078274

[SergeyBiryukov]

33091.2.diff​ adds a translator comment. Suggestions for the text are welcome.

[markjaquith]

@SergeyBiryukov — wouldn't have phrased it differently myself! Look good except for the lack of a closing PHP tag. ;-)

[markjaquith]

In r33437:

Add a translator note for the fix in r33387

props SergeyBiryukov
fixes #33091

[ocean90]

The translator comment needs to be directly before the string. It's currently assigned to the "Important:" string.

[SergeyBiryukov]

In 33441:

Move the translator note added in [33437] directly before the string it applies to.

fixes #33091.