Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33101 closed defect (bug) (fixed)

Two error messages defined for a single error

Reported by: gounder's profile gounder Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.7
Component: Users Keywords: good-first-bug has-patch needs-testing
Focuses: administration Cc:

Description

If a user enters a password only once in the edit user profile page, two error messages show up, one for the password not matching and another for the passwords not matching. The second Error message can be dropped or combined with the first one.
http://www.gounder.co.in/wp-content/uploads/2015/07/Screen-Shot-2015-07-23-at-21.13.25.png

Attachments (4)

33101.1.patch (702 bytes) - added by jmayhak 9 years ago.
33101.diff (1.2 KB) - added by MikeHansenMe 9 years ago.
33239.2.patch (1.2 KB) - added by jmayhak 9 years ago.
33101-3.patch (1.7 KB) - added by desrosj 9 years ago.

Download all attachments as: .zip

Change History (22)

#1 @Ankit K Gupta
9 years ago

After the WP 4.3 release, There will be not any option to fill password twice.
User will fill password only once.

#2 @MikeHansenMe
9 years ago

When JS is disabled there is still 2 fields that show. The two message although similar are different errors. One is a mismatch and the other is empty. I think we could remove the empty error probably as the mismatch covers both scenarios.

#3 @johnbillion
9 years ago

  • Keywords needs-patch good-first-bug added
  • Version changed from 4.2.3 to 3.7

@jmayhak
9 years ago

#4 @jmayhak
9 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#5 @MikeHansenMe
9 years ago

@jmayhak thanks for the patch. Can we also remove the empty message?

#6 @jmayhak
9 years ago

@MikeHansenMe Sorry, I don't follow. A message that is shown when no password is provided (empty)?

@MikeHansenMe
9 years ago

#7 @MikeHansenMe
9 years ago

33101.diff is what I was thinking but did not look at it too much. Would still need testing.

#8 @gounder
9 years ago

If you fill only one of the new password field you get two messages one for the passwords not matching the other for saying both fields need to be filled.

#9 @jmayhak
9 years ago

@MikeHansenMe I see. That section would need to stay because that's the error shown if you only enter 1 password. The error "Please enter the same password in the two password fields" won't show.

#10 @MikeHansenMe
9 years ago

"Please enter the same password in the two password fields." seems to cover both scenarios.

If one of the two is empty and also if they do not match.

@jmayhak
9 years ago

#11 @jmayhak
9 years ago

33239.2.patch makes sense to me

#12 @MikeHansenMe
9 years ago

  • Milestone changed from Awaiting Review to Future Release

#13 @SergeyBiryukov
9 years ago

  • Milestone changed from Future Release to 4.4

This ticket was mentioned in Slack in #core by sergey. View the logs.


9 years ago

#15 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

@desrosj
9 years ago

#16 @desrosj
9 years ago

@jmayhak's patch works for me and everything looks good.

May I suggest "Please enter the same password in both password fields."?

#17 @SergeyBiryukov
9 years ago

Introduced in [642].

#18 @SergeyBiryukov
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 35008:

Users: Remove redundant error message when password is only entered once.

"Please enter the same password in both password fields" should cover all the scenarios.

Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101.

Note: See TracTickets for help on using tickets.