WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#33114 closed defect (bug) (fixed)

Menu Customizer: completely hide inactive reorder buttons from assistive technologies

Reported by: afercia Owned by: ocean90
Priority: normal Milestone: 4.3
Component: Customize Version: 4.3
Severity: normal Keywords: has-patch
Cc: Focuses: accessibility, javascript

Description

When the menu items reorder buttons are disabled, they have a tabindex="-1" attribute set to remove them from tab order. By the way screen reader users can still use arrows to read content as they normally do for any element in the page. See in the screenshot below how using arrows the disabled buttons are actually announced.

I'd propose to completely hide them using also aria-hidden="true". This way, users will get only the controls they can actually use, reducing noise and potential confusion.

https://cldup.com/qdtLNtErnc.png

Attachments (1)

33114.patch​ (1.5 KB ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core-customize by afercia. ​View the logs.
11 years ago

#3 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution → fixed
  • Status new → closed

In 33412:

Customizer: Hide inactive reorder buttons for menu items from assistive technologies.

props afercia.
fixes #33114.

#4 @ocean90
11 years ago

  • Milestone Awaiting Review → 4.3
Note: See TracTickets for help on using tickets.