WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33121, comment 18


Ignore:
Timestamp:
10/12/2018 11:20:30 AM (12 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33121, comment 18

    initial v1  
    66> I'm not sure this (overriding of unset attributes) is the case if we require the hyphen following any prefixes, so a developer won't be able to add `href-*` and bypass checking.
    77
    8 Ah, I see, my error. The regex matches only attribute names that have a hyphen.
     8Ah, I see, my error. Now the regex matches only attribute names that have a hyphen.
    99
    1010I'm still not sold on supporting all of these attribute names "globally" with no possibility to check the values. Except `data-*`, none of them have variable names and imho should be added the same way like the rest of the attributes are added: by full name.