WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33137 closed defect (bug) (fixed)

Fullscreen is broken in iOS Safari

Reported by: iseulde Owned by: azaozz
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: TinyMCE Keywords:
Focuses: Cc:
PR Number:

Description

You can't scroll.

Attachments (3)

33137.patch (783 bytes) - added by iseulde 4 years ago.
33137.1.patch (783 bytes) - added by azaozz 4 years ago.
editor fullscreen nexus 5.png (68.6 KB) - added by ryan 4 years ago.
Fullscreen on a Nexus 5 with some filler text to induce scrolling

Download all attachments as: .zip

Change History (13)

@iseulde
4 years ago

@azaozz
4 years ago

#1 @azaozz
4 years ago

In 33137.1.patch: disable TinyMCE fullscreen on iOS. Works well on Android and all other browsers.

This ticket was mentioned in Slack in #core-flow by azaozz. View the logs.


4 years ago

#3 @ryan
4 years ago

I see scroll bleed on my iPhone 6+. We've battled scroll bleed on iOS so often that there's a tag and glossary entry for it.

https://make.wordpress.org/flow/tag/scroll-bleed/

https://make.wordpress.org/flow/handbook/glossary/#scroll-bleed

Android does not usually exhibit scroll bleed. I tested fullscreen on a Nexus 5, and editor scrolling was fine.

@ryan
4 years ago

Fullscreen on a Nexus 5 with some filler text to induce scrolling

#4 @iseulde
4 years ago

IMHO, fullscreen should always be removed on phones.

This ticket was mentioned in Slack in #core-editor by azaozz. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by azaozz. View the logs.


4 years ago

#7 @miqrogroove
4 years ago

  • Version set to trunk

I was unable to repro bug on 4.2.4. Appears to be a regression in 4.3 RC2.

#8 @samuelsidler
4 years ago

I think fullscreen should be removed on phones too. The clutter is already hidden by nature of the small screen. :)

#9 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 33835:

TinyMCE: disable the native fullscreen plugin on mobile devices by default.
Props iseulde. Fixes #33137;

#10 @azaozz
4 years ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 4.4
Note: See TracTickets for help on using tickets.